From ee4e650129c46a6ad658e6ad01b62c4bbe53fb63 Mon Sep 17 00:00:00 2001 From: Angel Montenegro Date: Mon, 6 Jan 2025 09:37:29 -0600 Subject: [PATCH 1/3] Use the numerical id of the group id instead of the actual valie (#2438) --- src/app/cdk/panel/panel/panel.component.ts | 7 +++---- .../record-peer-review/record-peer-review.service.ts | 9 ++++----- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/app/cdk/panel/panel/panel.component.ts b/src/app/cdk/panel/panel/panel.component.ts index b57923490..117a7348d 100644 --- a/src/app/cdk/panel/panel/panel.component.ts +++ b/src/app/cdk/panel/panel/panel.component.ts @@ -289,12 +289,11 @@ export class PanelComponent implements OnInit { ) .subscribe() break - case 'peer-review': + case 'peer-review': this._peerReviewService .updateVisibility( - this.elements.groupIdValue, - visibility, - this.elements?.groupId + this.elements.groupId, + visibility ) .subscribe() break diff --git a/src/app/core/record-peer-review/record-peer-review.service.ts b/src/app/core/record-peer-review/record-peer-review.service.ts index 58c52b1a9..d4360ec26 100644 --- a/src/app/core/record-peer-review/record-peer-review.service.ts +++ b/src/app/core/record-peer-review/record-peer-review.service.ts @@ -117,15 +117,14 @@ export class RecordPeerReviewService { } updateVisibility( - putCode: any, - visibility: VisibilityStrings, - groupId?: any - ): Observable { + groupId: any, + visibility: VisibilityStrings + ): Observable { return this._http .post( environment.API_WEB + 'peer-reviews/' + - putCode + + groupId + '/visibility/' + visibility, null From 7b433e6d3ba94df52628404f69454ee5d2f0bbbc Mon Sep 17 00:00:00 2001 From: amontenegro Date: Mon, 6 Jan 2025 15:43:28 +0000 Subject: [PATCH 2/3] =?UTF-8?q?=F0=9F=A4=96=20GITHUB=20ACTIONS=20format=5F?= =?UTF-8?q?prettier?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/app/cdk/panel/panel/panel.component.ts | 7 ++----- .../core/record-peer-review/record-peer-review.service.ts | 2 +- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/app/cdk/panel/panel/panel.component.ts b/src/app/cdk/panel/panel/panel.component.ts index 117a7348d..ca14e0e15 100644 --- a/src/app/cdk/panel/panel/panel.component.ts +++ b/src/app/cdk/panel/panel/panel.component.ts @@ -289,12 +289,9 @@ export class PanelComponent implements OnInit { ) .subscribe() break - case 'peer-review': + case 'peer-review': this._peerReviewService - .updateVisibility( - this.elements.groupId, - visibility - ) + .updateVisibility(this.elements.groupId, visibility) .subscribe() break case 'top-bar': diff --git a/src/app/core/record-peer-review/record-peer-review.service.ts b/src/app/core/record-peer-review/record-peer-review.service.ts index d4360ec26..0646b7f0c 100644 --- a/src/app/core/record-peer-review/record-peer-review.service.ts +++ b/src/app/core/record-peer-review/record-peer-review.service.ts @@ -119,7 +119,7 @@ export class RecordPeerReviewService { updateVisibility( groupId: any, visibility: VisibilityStrings - ): Observable { + ): Observable { return this._http .post( environment.API_WEB + From 3e212e5dc9ec8b6620c5e1e13f2d5d74008eb57b Mon Sep 17 00:00:00 2001 From: github actions Date: Mon, 6 Jan 2025 15:58:54 +0000 Subject: [PATCH 3/3] v2.109.15 changelog update --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f1050ab09..25a60799d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## v2.109.15 - 2025-01-06 + +[Full Changelog](https://github.com/ORCID/orcid-angular/compare/v2.109.14...v2.109.15) + ## v2.109.14 - 2025-01-03 [Full Changelog](https://github.com/ORCID/orcid-angular/compare/v2.109.13...v2.109.14)