Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProgramStateMachineState support transitions not correctly #634

Closed
Hevgen opened this issue Feb 2, 2019 · 2 comments · Fixed by #2877
Closed

ProgramStateMachineState support transitions not correctly #634

Hevgen opened this issue Feb 2, 2019 · 2 comments · Fixed by #2877
Assignees
@EthanChangAED
Labels
help wanted needs investigation statemachine Related to statemachine

Comments

@Hevgen
Copy link

Hevgen commented Feb 2, 2019

Class ProgramStateMachineState has wrong and missed entries at s_CauseMappings array:

  1. RunningToReady is caused by Reset() method but it should be Internal caused only.
  2. SuspendedToReady is caused by Reset() method but it should be Internal caused only.
  3. ReadyToHalted transition is missed but should be caused by Halt() method.

My opinion is based on OPC Unified Architecture Specification Part 10: Programs (Release 1.04).
@mrsuciu mrsuciu added statemachine Related to statemachine help wanted labels Sep 9, 2021
@EthanChangAED
Copy link

Hello @Hevgen, are you still seeing this issue?

@EthanChangAED EthanChangAED added the Pending Feedback Pending on further feedbacks or clarification from person who create the issue. label Aug 4, 2023
@Hevgen
Copy link
Author

Hevgen commented Aug 6, 2023

Hello.
yes. All three sub-issues exist.
Transition ReadyToHalted exists now but has no cause in ProgramStateMachineState.s_CauseMappings (should be caused by Methods.ProgramStateMachineType_Halt).

My opinion is based on Part 10: Programs. p.4.2.3 Program Finite State Machine (release 1.05)

@EthanChangAED EthanChangAED removed the Pending Feedback Pending on further feedbacks or clarification from person who create the issue. label Dec 20, 2023
@Archie-Miller Archie-Miller mentioned this issue Dec 2, 2024
Merged
10 tasks
@Archie-Miller Archie-Miller linked a pull request Dec 2, 2024 that will close this issue
Update CauseMappings to reflect issue 634 - support transitions not correctly #2877
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EthanChangAED EthanChangAED

Labels
help wanted needs investigation statemachine Related to statemachine
Projects
None yet
Milestone
No milestone
5 participants
@AlinMoldovean @Hevgen @mrsuciu @EthanChangAED @Archie-Miller