Missing enumerable reducing before caching causes major performance degradation

[nsarris]

odata.net/src/Microsoft.OData.Edm/Csdl/Semantics/CsdlSemanticsNavigationSource.cs

Line 137 in acf4f43

navigationBindingList = this.NavigationPropertyBindings.Where(targetMapping => targetMapping.NavigationProperty == navigationProperty);

An attempt to improve performance was commited in the last version by caching FindNavigationPropertyBindings.FindNavigationPropertyBindings. Unfortunately instead of caching the materialized list of results the enumerable was cached resulting in even more performance degradation.

This fix is to simple add .ToList() on the enumerable.

[habbes]

Thanks @nsarris for reporting this. We'll look into this and patch it (cc @Sreejithpin )