Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter matching for resolving function overloads has an issue #1649

Open
KanishManuja-MS opened this issue Jan 28, 2020 · 0 comments
Open
Labels

Comments

@KanishManuja-MS
Copy link
Contributor

KanishManuja-MS commented Jan 28, 2020

There is a bug in the way we match URI parameters to function parameters. For case-insensitive matching, the same parameter in the URI can be used to match with multiple parameters in the function's uri. It is uncommon for functions to have the same name for parameters but it is possible.

private static bool ParametersSatisfyFunction(IEdmOperation operation, IList<string> parameterNameList, bool caseInsensitive)

Assemblies affected

Which assemblies and versions are known to be affected e.g. OData .Net lib 7.x
ODL 7.x

Reproduce steps

Add a function that takes two parameters that have the same name but only differ in case. Specify only one parameter in the request. The function will be considered a match if it is the only function.

Expected result

The function should not be considered a match.

Actual result

The function is considered a match.

@KanishManuja-MS KanishManuja-MS changed the title Parameter matching for function has an issue Parameter matching for resolving function overloads has an issue Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants