Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert writing empty parens for expanded nav prop in 4.0 response #1383

Closed
mikepizzo opened this issue Jan 24, 2019 · 1 comment
Closed

Revert writing empty parens for expanded nav prop in 4.0 response #1383

mikepizzo opened this issue Jan 24, 2019 · 1 comment
Milestone

Comments

@mikepizzo
Copy link
Member

PR #1286 fixed issue #1265 (along with others) by including an empty parens in the ContextUrl for expanded entities with no expand options specified.

This is required in 4.01 and suggested in 4.0.

Although empty parens should be supported for 4.0, and clients using our 4.0 libraries are able to consume this, we have at least two incidents of customers parsing the contextUrl on their own which are not expecting the empty parens in this case.

To be safe, we should make adding the empty parens written only for 4.01 responses.

@mikepizzo
Copy link
Member Author

Doesn't seem worth fixing at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant