Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recursive clone of ocrd_olena bloats docker image with assets #360

Closed
bertsky opened this issue Mar 17, 2023 · 3 comments · Fixed by #356
Closed

recursive clone of ocrd_olena bloats docker image with assets #360

bertsky opened this issue Mar 17, 2023 · 3 comments · Fixed by #356

Comments

@bertsky
Copy link
Collaborator

bertsky commented Mar 17, 2023

ocrd_all/Makefile

Line 363 in d8830fb

ocrd_olena: GIT_RECURSIVE = --recursive

This causes all docker images to contain a complete checkout of the assets test data repository. (Twice even, because of the .git index.)
@bertsky
Copy link
Collaborator Author

bertsky commented Mar 17, 2023

They sum up to 315 MB.

@bertsky bertsky linked a pull request Mar 18, 2023 that will close this issue
update 2023-03-16 #356
Merged
@kba
Copy link
Member

kba commented Mar 22, 2023

Shouldn't the .dockerignore entry */assets prevent that?

@bertsky
Copy link
Collaborator Author

bertsky commented Mar 22, 2023

Shouldn't the .dockerignore entry */assets prevent that?

No, it did not. (Did not apply recursively.)

See my other comment and the actual change.

@kba kba closed this as completed in #356 Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update 2023-03-16 OCR-D/ocrd_all
2 participants
@kba @bertsky