Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make all with Python 3.7 fails to build ocrd_detectron2 #291

Closed
stweil opened this issue Mar 7, 2022 · 2 comments · Fixed by #356
Closed

make all with Python 3.7 fails to build ocrd_detectron2 #291

stweil opened this issue Mar 7, 2022 · 2 comments · Fixed by #356
Assignees

Comments

@stweil
Copy link
Collaborator

stweil commented Mar 7, 2022

The build aborts with this error message:

ERROR: Could not find a version that satisfies the requirement detectron2>=0.6 (from versions: none)

I could fix it locally in the main venv (no need to use sub-venv/headless-torch14) using these commands:

cd ocrd_detectron2
pip install 'git+https://github.com/facebookresearch/detectron2.git'
pip install -r requirements.txt
pip install .

Building detectron2 instead of trying to get (non-existing) pre-built packages would also support more platforms which currently would also fail (non Linux hosts, non x86_64 architectures).

@bertsky
Copy link
Collaborator

bertsky commented Mar 16, 2022

Building detectron2 instead of trying to get (non-existing) pre-built packages would also support more platforms which currently would also fail (non Linux hosts, non x86_64 architectures).

That does not work in general though. (You have to accommodate Python, Pytorch and Detectron versions against each other. Even the official setup manual does not do it this way.) Plus it will take very long. (Plus we might not want to depend on unstable master.)

@stweil
Copy link
Collaborator Author

stweil commented Mar 16, 2022

Did you try it? It does not take long in my build (only a few seconds), and it works for Python 3.7, 3.9 and 3.10 (I did not test 3.8). For Python 3.6 we'd have to use the current rules.

And sure, for production we should add a specific tag to the GitHub URL. That's easy.

@bertsky bertsky linked a pull request Mar 18, 2023 that will close this issue
@kba kba closed this as completed in #356 Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants