[16.0][FIX] fs_attachment: Avoid local variable redefine #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmignon
force-pushed
the
16.0-fs-attachment-fix-var-scope
branch
from
c89b0cd to
884a83b
Compare
When manipulating the file system api through a local variable named *fs*, we observed some strange behavior when it was wrongly redefined in an enclosing scope as in the following example: *with fs.open(...) as fs*. This commit fixes this issue by renaming the local variable and therefore avoiding the name clash.
lmignon
force-pushed
the
16.0-fs-attachment-fix-var-scope
branch
from
884a83b to
c9c73a6
Compare
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 8fa213a. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When manipulating the file system api through a local variable named fs, we observed some strange behavior when it was wrongly redefined in an enclosing scope as in the following example: with fs.open(...) as fs.
This PR fixes this issue by renaming the local variable and therefore avoiding the name clash.