From 8f3d30ed6f4a3dfc88ccb156a8cf0db14b396e4b Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Mon, 24 Apr 2023 13:23:44 -0400 Subject: [PATCH 01/10] Test against ember-concurrency@v3 --- .changeset/thin-rules-scream.md | 5 ++++ .github/workflows/ci.yml | 1 + ember-resources/package.json | 2 +- pnpm-lock.yaml | 44 ++++++++++++++++----------------- test-app/config/ember-try.js | 8 ++++++ 5 files changed, 37 insertions(+), 23 deletions(-) create mode 100644 .changeset/thin-rules-scream.md diff --git a/.changeset/thin-rules-scream.md b/.changeset/thin-rules-scream.md new file mode 100644 index 000000000..45eb62ada --- /dev/null +++ b/.changeset/thin-rules-scream.md @@ -0,0 +1,5 @@ +--- +"ember-resources": patch +--- + +Test against ember-concurrency@v3, and add it as an allowed peerDepnedency diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index dce707e6c..27d78ba47 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -120,6 +120,7 @@ jobs: - ember-release - ember-beta - ember-canary + - ember-concurrency-3 - embroider-safe - embroider-optimized diff --git a/ember-resources/package.json b/ember-resources/package.json index 12f359351..5348ca062 100644 --- a/ember-resources/package.json +++ b/ember-resources/package.json @@ -109,7 +109,7 @@ "@glimmer/tracking": "^1.1.2", "@glint/template": "^1.0.0-beta.3 || ^1.0.0", "ember-async-data": "^1.0.1", - "ember-concurrency": "^2.0.0", + "ember-concurrency": "^2.0.0 || ^3.0.0", "ember-source": "^3.28.0 || ^4.0.0 || ^5.0.0" }, "peerDependenciesMeta": { diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 862c3b286..7921d02cd 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -109,8 +109,8 @@ importers: specifier: ^1.2.0 version: 1.6.0 ember-concurrency: - specifier: ^2.0.0 - version: 2.0.0(@babel/core@7.21.4) + specifier: ^2.0.0 || ^3.0.0 + version: 2.2.1(@babel/core@7.21.4) devDependencies: '@babel/core': specifier: 7.21.4 @@ -4096,7 +4096,7 @@ packages: resolution: {integrity: sha512-G6kbLaS3ke4QspHkgLlGY0t1v0G22hGavyphezZucj7LLk1N+r11w913CYkBg3cJsJD+TG2Wo4eVbgRcotvuvQ==} dependencies: '@types/ember': 4.0.3(@babel/core@7.21.4) - '@types/ember__object': 4.0.5(@babel/core@7.21.3) + '@types/ember__object': 4.0.5(@babel/core@7.21.4) transitivePeerDependencies: - '@babel/core' - supports-color @@ -4116,7 +4116,7 @@ packages: resolution: {integrity: sha512-qHjCGo1p9I4VJR3qfil7h0jJWTy52uNJw87MNwNEi1SYk+EaVJaqyyyoZHJmZGdn8hw3JjXvyFt/zeFZpbK/6A==} dependencies: '@types/ember': 4.0.3(@babel/core@7.21.4) - '@types/ember__object': 4.0.5(@babel/core@7.21.3) + '@types/ember__object': 4.0.5(@babel/core@7.21.4) transitivePeerDependencies: - '@babel/core' - supports-color @@ -4238,9 +4238,9 @@ packages: resolution: {integrity: sha512-zxPS43JP8/dEmNrSucN5KzTvOm+JUrbFGWsJ1m5a395FwxYbpgs7JujV0JWl+eVhnCh/PmsNcCdJT16+jouktQ==} dependencies: '@types/ember': 4.0.3(@babel/core@7.21.3) - '@types/ember__controller': 4.0.4(@babel/core@7.21.3) - '@types/ember__object': 4.0.5(@babel/core@7.21.3) - '@types/ember__service': 4.0.2(@babel/core@7.21.3) + '@types/ember__controller': 4.0.4(@babel/core@7.21.4) + '@types/ember__object': 4.0.5(@babel/core@7.21.4) + '@types/ember__service': 4.0.2(@babel/core@7.21.4) transitivePeerDependencies: - '@babel/core' - supports-color @@ -4250,9 +4250,9 @@ packages: resolution: {integrity: sha512-zxPS43JP8/dEmNrSucN5KzTvOm+JUrbFGWsJ1m5a395FwxYbpgs7JujV0JWl+eVhnCh/PmsNcCdJT16+jouktQ==} dependencies: '@types/ember': 4.0.3(@babel/core@7.21.4) - '@types/ember__controller': 4.0.4(@babel/core@7.21.3) - '@types/ember__object': 4.0.5(@babel/core@7.21.3) - '@types/ember__service': 4.0.2(@babel/core@7.21.3) + '@types/ember__controller': 4.0.4(@babel/core@7.21.4) + '@types/ember__object': 4.0.5(@babel/core@7.21.4) + '@types/ember__service': 4.0.2(@babel/core@7.21.4) transitivePeerDependencies: - '@babel/core' - supports-color @@ -8389,29 +8389,29 @@ packages: - supports-color dev: false - /ember-concurrency@2.0.0(@babel/core@7.21.4): - resolution: {integrity: sha512-qFpxIaWdBcWM3fjN6CrNaXNTBRVbdympyQMM30GYMoyVKxM0JhzlOelPtGOKkG9uL3dAB5phJ0bfKtoO5x6mnQ==} - engines: {node: 10.* || >= 12} + /ember-concurrency@2.2.1(@babel/core@7.21.3): + resolution: {integrity: sha512-a4283Yq+jimxqoD5YaxQu7cXePHKqkNQfsT4fs0nYTz5PYbUd6wzUtelp6k8R1JTNPwDdxyVvUgu7yYoC8Sk5A==} + engines: {node: 10.* || 12.* || 14.* || >= 16} dependencies: '@glimmer/tracking': 1.1.2 ember-cli-babel: 7.26.11 ember-cli-htmlbars: 5.7.2 - ember-compatibility-helpers: 1.2.6(@babel/core@7.21.4) - ember-destroyable-polyfill: 2.0.3(@babel/core@7.21.4) + ember-compatibility-helpers: 1.2.6(@babel/core@7.21.3) + ember-destroyable-polyfill: 2.0.3(@babel/core@7.21.3) transitivePeerDependencies: - '@babel/core' - supports-color dev: false - /ember-concurrency@2.2.1(@babel/core@7.21.3): + /ember-concurrency@2.2.1(@babel/core@7.21.4): resolution: {integrity: sha512-a4283Yq+jimxqoD5YaxQu7cXePHKqkNQfsT4fs0nYTz5PYbUd6wzUtelp6k8R1JTNPwDdxyVvUgu7yYoC8Sk5A==} engines: {node: 10.* || 12.* || 14.* || >= 16} dependencies: '@glimmer/tracking': 1.1.2 ember-cli-babel: 7.26.11 ember-cli-htmlbars: 5.7.2 - ember-compatibility-helpers: 1.2.6(@babel/core@7.21.3) - ember-destroyable-polyfill: 2.0.3(@babel/core@7.21.3) + ember-compatibility-helpers: 1.2.6(@babel/core@7.21.4) + ember-destroyable-polyfill: 2.0.3(@babel/core@7.21.4) transitivePeerDependencies: - '@babel/core' - supports-color @@ -9090,7 +9090,7 @@ packages: eslint-import-resolver-webpack: optional: true dependencies: - '@typescript-eslint/parser': 5.54.0(eslint@8.35.0)(typescript@5.0.3) + '@typescript-eslint/parser': 5.54.0(eslint@8.35.0)(typescript@4.8.2) debug: 3.2.7 eslint: 8.35.0 eslint-import-resolver-node: 0.3.7 @@ -9110,7 +9110,7 @@ packages: optional: true dependencies: '@babel/core': 7.21.4(supports-color@8.1.1) - '@babel/eslint-parser': 7.19.1(@babel/core@7.21.4)(eslint@8.35.0) + '@babel/eslint-parser': 7.19.1(@babel/core@7.21.3)(eslint@8.35.0) '@babel/plugin-proposal-decorators': 7.21.0(@babel/core@7.21.4) '@ember-data/rfc395-data': 0.0.4 ember-rfc176-data: 0.3.18 @@ -9175,7 +9175,7 @@ packages: '@typescript-eslint/parser': optional: true dependencies: - '@typescript-eslint/parser': 5.54.0(eslint@8.35.0)(typescript@5.0.3) + '@typescript-eslint/parser': 5.54.0(eslint@8.35.0)(typescript@4.8.2) array-includes: 3.1.6 array.prototype.flat: 1.3.1 array.prototype.flatmap: 1.3.1 @@ -15624,7 +15624,7 @@ packages: '@glimmer/tracking': ^1.1.2 '@glint/template': ^1.0.0-beta.3 || ^1.0.0 ember-async-data: ^1.0.1 - ember-concurrency: ^2.0.0 + ember-concurrency: ^2.0.0 || ^3.0.0 ember-source: ^3.28.0 || ^4.0.0 || ^5.0.0 peerDependenciesMeta: '@ember/test-waiters': diff --git a/test-app/config/ember-try.js b/test-app/config/ember-try.js index 5484dd44d..12ae5d239 100644 --- a/test-app/config/ember-try.js +++ b/test-app/config/ember-try.js @@ -47,6 +47,14 @@ module.exports = async function () { }, }, }, + { + name: 'ember-concurrency-3', + npm: { + devDependencies: { + 'ember-concurrency': '^3.0.0', + }, + }, + }, { name: 'ember-release', npm: { From 3121b573e1e6a11392128b987b7965b7f8491c2f Mon Sep 17 00:00:00 2001 From: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com> Date: Mon, 24 Apr 2023 15:29:24 -0400 Subject: [PATCH 02/10] Create separate test apps for ember-concurrency --- .github/workflows/ci.yml | 22 +- pnpm-lock.yaml | 111 +------ test-app-ember-concurrency-2/.editorconfig | 19 ++ test-app-ember-concurrency-2/.ember-cli | 9 + test-app-ember-concurrency-2/.eslintignore | 27 ++ test-app-ember-concurrency-2/.eslintrc.js | 40 +++ test-app-ember-concurrency-2/.gitignore | 26 ++ test-app-ember-concurrency-2/.prettierignore | 23 ++ test-app-ember-concurrency-2/.prettierrc.js | 30 ++ .../.template-lintrc.js | 14 + test-app-ember-concurrency-2/.watchmanconfig | 3 + test-app-ember-concurrency-2/app/app.ts | 13 + .../app/config/environment.d.ts | 15 + test-app-ember-concurrency-2/app/index.html | 25 ++ test-app-ember-concurrency-2/app/router.ts | 12 + .../app/styles/app.css | 0 .../config/dependency-lint.js | 3 + .../config/ember-cli-update.json | 18 ++ .../config/ember-try.js | 107 +++++++ .../config/environment.js | 55 ++++ .../config/optional-features.json | 6 + .../config/targets.js | 22 ++ .../ember-cli-build.js | 47 +++ test-app-ember-concurrency-2/package.json | 142 ++++++++ .../public/mockServiceWorker.js | 303 ++++++++++++++++++ .../public/robots.txt | 3 + test-app-ember-concurrency-2/testem.js | 23 ++ test-app-ember-concurrency-2/tests/index.html | 36 +++ .../tests/test-helper.ts | 25 ++ .../tests/utils/ember-concurrency/js-test.ts | 0 .../ember-concurrency/rendering-test.gts | 0 test-app-ember-concurrency-2/tsconfig.json | 15 + .../types/ember-app/index.d.ts | 70 ++++ .../ember-data/types/registries/model.d.ts | 6 + .../types/glint-registry.d.ts | 14 + .../types/global.d.ts | 6 + test-app-ember-concurrency-2/types/index.d.ts | 3 + test-app-ember-concurrency-2/vendor/.gitkeep | 0 test-app-ember-concurrency-3/.editorconfig | 19 ++ test-app-ember-concurrency-3/.ember-cli | 9 + test-app-ember-concurrency-3/.eslintignore | 27 ++ test-app-ember-concurrency-3/.eslintrc.js | 40 +++ test-app-ember-concurrency-3/.gitignore | 26 ++ test-app-ember-concurrency-3/.prettierignore | 23 ++ test-app-ember-concurrency-3/.prettierrc.js | 30 ++ .../.template-lintrc.js | 14 + test-app-ember-concurrency-3/.watchmanconfig | 3 + test-app-ember-concurrency-3/app/app.ts | 13 + .../app/config/environment.d.ts | 15 + test-app-ember-concurrency-3/app/index.html | 25 ++ test-app-ember-concurrency-3/app/router.ts | 12 + .../app/styles/app.css | 0 .../config/dependency-lint.js | 3 + .../config/ember-cli-update.json | 18 ++ .../config/ember-try.js | 107 +++++++ .../config/environment.js | 55 ++++ .../config/optional-features.json | 6 + .../config/targets.js | 22 ++ .../ember-cli-build.js | 47 +++ test-app-ember-concurrency-3/package.json | 142 ++++++++ .../public/mockServiceWorker.js | 303 ++++++++++++++++++ .../public/robots.txt | 3 + test-app-ember-concurrency-3/testem.js | 23 ++ test-app-ember-concurrency-3/tests/index.html | 36 +++ .../tests/test-helper.ts | 25 ++ .../tests/utils/ember-concurrency/js-test.ts | 205 ++++++++++++ .../ember-concurrency/rendering-test.gts | 285 ++++++++++++++++ test-app-ember-concurrency-3/tsconfig.json | 15 + .../types/ember-app/index.d.ts | 70 ++++ .../ember-data/types/registries/model.d.ts | 6 + .../types/glint-registry.d.ts | 14 + .../types/global.d.ts | 6 + test-app-ember-concurrency-3/types/index.d.ts | 3 + test-app-ember-concurrency-3/vendor/.gitkeep | 0 test-app/config/ember-try.js | 8 - test-app/package.json | 2 - 76 files changed, 2845 insertions(+), 108 deletions(-) create mode 100644 test-app-ember-concurrency-2/.editorconfig create mode 100644 test-app-ember-concurrency-2/.ember-cli create mode 100644 test-app-ember-concurrency-2/.eslintignore create mode 100644 test-app-ember-concurrency-2/.eslintrc.js create mode 100644 test-app-ember-concurrency-2/.gitignore create mode 100644 test-app-ember-concurrency-2/.prettierignore create mode 100644 test-app-ember-concurrency-2/.prettierrc.js create mode 100644 test-app-ember-concurrency-2/.template-lintrc.js create mode 100644 test-app-ember-concurrency-2/.watchmanconfig create mode 100644 test-app-ember-concurrency-2/app/app.ts create mode 100644 test-app-ember-concurrency-2/app/config/environment.d.ts create mode 100644 test-app-ember-concurrency-2/app/index.html create mode 100644 test-app-ember-concurrency-2/app/router.ts create mode 100644 test-app-ember-concurrency-2/app/styles/app.css create mode 100644 test-app-ember-concurrency-2/config/dependency-lint.js create mode 100644 test-app-ember-concurrency-2/config/ember-cli-update.json create mode 100644 test-app-ember-concurrency-2/config/ember-try.js create mode 100644 test-app-ember-concurrency-2/config/environment.js create mode 100644 test-app-ember-concurrency-2/config/optional-features.json create mode 100644 test-app-ember-concurrency-2/config/targets.js create mode 100644 test-app-ember-concurrency-2/ember-cli-build.js create mode 100644 test-app-ember-concurrency-2/package.json create mode 100644 test-app-ember-concurrency-2/public/mockServiceWorker.js create mode 100644 test-app-ember-concurrency-2/public/robots.txt create mode 100644 test-app-ember-concurrency-2/testem.js create mode 100644 test-app-ember-concurrency-2/tests/index.html create mode 100644 test-app-ember-concurrency-2/tests/test-helper.ts rename {test-app => test-app-ember-concurrency-2}/tests/utils/ember-concurrency/js-test.ts (100%) rename {test-app => test-app-ember-concurrency-2}/tests/utils/ember-concurrency/rendering-test.gts (100%) create mode 100644 test-app-ember-concurrency-2/tsconfig.json create mode 100644 test-app-ember-concurrency-2/types/ember-app/index.d.ts create mode 100644 test-app-ember-concurrency-2/types/ember-data/types/registries/model.d.ts create mode 100644 test-app-ember-concurrency-2/types/glint-registry.d.ts create mode 100644 test-app-ember-concurrency-2/types/global.d.ts create mode 100644 test-app-ember-concurrency-2/types/index.d.ts create mode 100644 test-app-ember-concurrency-2/vendor/.gitkeep create mode 100644 test-app-ember-concurrency-3/.editorconfig create mode 100644 test-app-ember-concurrency-3/.ember-cli create mode 100644 test-app-ember-concurrency-3/.eslintignore create mode 100644 test-app-ember-concurrency-3/.eslintrc.js create mode 100644 test-app-ember-concurrency-3/.gitignore create mode 100644 test-app-ember-concurrency-3/.prettierignore create mode 100644 test-app-ember-concurrency-3/.prettierrc.js create mode 100644 test-app-ember-concurrency-3/.template-lintrc.js create mode 100644 test-app-ember-concurrency-3/.watchmanconfig create mode 100644 test-app-ember-concurrency-3/app/app.ts create mode 100644 test-app-ember-concurrency-3/app/config/environment.d.ts create mode 100644 test-app-ember-concurrency-3/app/index.html create mode 100644 test-app-ember-concurrency-3/app/router.ts create mode 100644 test-app-ember-concurrency-3/app/styles/app.css create mode 100644 test-app-ember-concurrency-3/config/dependency-lint.js create mode 100644 test-app-ember-concurrency-3/config/ember-cli-update.json create mode 100644 test-app-ember-concurrency-3/config/ember-try.js create mode 100644 test-app-ember-concurrency-3/config/environment.js create mode 100644 test-app-ember-concurrency-3/config/optional-features.json create mode 100644 test-app-ember-concurrency-3/config/targets.js create mode 100644 test-app-ember-concurrency-3/ember-cli-build.js create mode 100644 test-app-ember-concurrency-3/package.json create mode 100644 test-app-ember-concurrency-3/public/mockServiceWorker.js create mode 100644 test-app-ember-concurrency-3/public/robots.txt create mode 100644 test-app-ember-concurrency-3/testem.js create mode 100644 test-app-ember-concurrency-3/tests/index.html create mode 100644 test-app-ember-concurrency-3/tests/test-helper.ts create mode 100644 test-app-ember-concurrency-3/tests/utils/ember-concurrency/js-test.ts create mode 100644 test-app-ember-concurrency-3/tests/utils/ember-concurrency/rendering-test.gts create mode 100644 test-app-ember-concurrency-3/tsconfig.json create mode 100644 test-app-ember-concurrency-3/types/ember-app/index.d.ts create mode 100644 test-app-ember-concurrency-3/types/ember-data/types/registries/model.d.ts create mode 100644 test-app-ember-concurrency-3/types/glint-registry.d.ts create mode 100644 test-app-ember-concurrency-3/types/global.d.ts create mode 100644 test-app-ember-concurrency-3/types/index.d.ts create mode 100644 test-app-ember-concurrency-3/vendor/.gitkeep diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 27d78ba47..6085f481f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -120,7 +120,6 @@ jobs: - ember-release - ember-beta - ember-canary - - ember-concurrency-3 - embroider-safe - embroider-optimized @@ -134,6 +133,26 @@ jobs: node_modules/.bin/ember try:one ${{ matrix.try-scenario }} --skip-cleanup + test-ember-concurrency: + name: "w/ ${{ matrix.concurrencyVersion }}" + timeout-minutes: 5 + runs-on: ubuntu-latest + needs: [default_tests] + + strategy: + fail-fast: false + matrix: + concurrencyVersion: + - "test-app-ember-concurrency-2" + - "test-app-ember-concurrency-3" + + steps: + - uses: actions/checkout@v3 + - uses: NullVoxPopuli/action-setup-pnpm@v2 + - uses: ./.github/actions/download-built-package + - name: Run Tests + run: pnpm turbo test:ember + working-directory: ${{ matrix.concurrencyVersion }} # https://github.com/changesets/action @@ -147,6 +166,7 @@ jobs: - floating_tests - typecheck - try_scenarios + - test-ember-concurrency steps: - uses: actions/checkout@v3 diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 7921d02cd..a6608f770 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -244,18 +244,12 @@ importers: ember-async-data: specifier: ^1.0.1 version: 1.0.1(ember-source@4.11.0) - ember-concurrency: - specifier: 2.2.1 - version: 2.2.1(@babel/core@7.21.3) - ember-concurrency-ts: - specifier: ^0.3.1 - version: 0.3.1(ember-concurrency@2.2.1) ember-functions-as-helper-polyfill: specifier: ^2.0.1 version: 2.0.1 ember-resources: specifier: workspace:ember-resources@* - version: file:ember-resources(@ember/test-waiters@3.0.2)(@glimmer/component@1.1.2)(@glimmer/tracking@1.1.2)(@glint/template@1.0.0-beta.3)(ember-async-data@1.0.1)(ember-concurrency@2.2.1)(ember-source@4.11.0) + version: file:ember-resources(@ember/test-waiters@3.0.2)(@glimmer/component@1.1.2)(@glimmer/tracking@1.1.2)(@glint/template@1.0.0-beta.3)(ember-async-data@1.0.1)(ember-source@4.11.0) tracked-built-ins: specifier: ^3.1.0 version: 3.1.0 @@ -4096,7 +4090,7 @@ packages: resolution: {integrity: sha512-G6kbLaS3ke4QspHkgLlGY0t1v0G22hGavyphezZucj7LLk1N+r11w913CYkBg3cJsJD+TG2Wo4eVbgRcotvuvQ==} dependencies: '@types/ember': 4.0.3(@babel/core@7.21.4) - '@types/ember__object': 4.0.5(@babel/core@7.21.4) + '@types/ember__object': 4.0.5(@babel/core@7.21.3) transitivePeerDependencies: - '@babel/core' - supports-color @@ -4116,7 +4110,7 @@ packages: resolution: {integrity: sha512-qHjCGo1p9I4VJR3qfil7h0jJWTy52uNJw87MNwNEi1SYk+EaVJaqyyyoZHJmZGdn8hw3JjXvyFt/zeFZpbK/6A==} dependencies: '@types/ember': 4.0.3(@babel/core@7.21.4) - '@types/ember__object': 4.0.5(@babel/core@7.21.4) + '@types/ember__object': 4.0.5(@babel/core@7.21.3) transitivePeerDependencies: - '@babel/core' - supports-color @@ -4238,9 +4232,9 @@ packages: resolution: {integrity: sha512-zxPS43JP8/dEmNrSucN5KzTvOm+JUrbFGWsJ1m5a395FwxYbpgs7JujV0JWl+eVhnCh/PmsNcCdJT16+jouktQ==} dependencies: '@types/ember': 4.0.3(@babel/core@7.21.3) - '@types/ember__controller': 4.0.4(@babel/core@7.21.4) - '@types/ember__object': 4.0.5(@babel/core@7.21.4) - '@types/ember__service': 4.0.2(@babel/core@7.21.4) + '@types/ember__controller': 4.0.4(@babel/core@7.21.3) + '@types/ember__object': 4.0.5(@babel/core@7.21.3) + '@types/ember__service': 4.0.2(@babel/core@7.21.3) transitivePeerDependencies: - '@babel/core' - supports-color @@ -4250,9 +4244,9 @@ packages: resolution: {integrity: sha512-zxPS43JP8/dEmNrSucN5KzTvOm+JUrbFGWsJ1m5a395FwxYbpgs7JujV0JWl+eVhnCh/PmsNcCdJT16+jouktQ==} dependencies: '@types/ember': 4.0.3(@babel/core@7.21.4) - '@types/ember__controller': 4.0.4(@babel/core@7.21.4) - '@types/ember__object': 4.0.5(@babel/core@7.21.4) - '@types/ember__service': 4.0.2(@babel/core@7.21.4) + '@types/ember__controller': 4.0.4(@babel/core@7.21.3) + '@types/ember__object': 4.0.5(@babel/core@7.21.3) + '@types/ember__service': 4.0.2(@babel/core@7.21.3) transitivePeerDependencies: - '@babel/core' - supports-color @@ -5543,11 +5537,6 @@ packages: '@babel/types': 7.21.4 lodash: 4.17.21 - /babel-plugin-htmlbars-inline-precompile@3.2.0: - resolution: {integrity: sha512-IUeZmgs9tMUGXYu1vfke5I18yYJFldFGdNFQOWslXTnDWXzpwPih7QFduUqvT+awDpDuNtXpdt5JAf43Q1Hhzg==} - engines: {node: 8.* || 10.* || >= 12.*} - dev: false - /babel-plugin-htmlbars-inline-precompile@5.3.1: resolution: {integrity: sha512-QWjjFgSKtSRIcsBhJmEwS2laIdrA6na8HAlc/pEAhjHgQsah/gMiBFRZvbQTy//hWxR4BMwV7/Mya7q5H8uHeA==} engines: {node: 10.* || >= 12.*} @@ -6422,14 +6411,6 @@ packages: resolution: {integrity: sha512-VabSGRpKIzpmC+r+tJueCE5h8k6vON7EIMMWu6d/FyPdtijwLQ7QvzShEw+m3mHoDzUaj/kiZsDYrS8X2adsBg==} engines: {node: 8.* || >= 10.*} - /broccoli-output-wrapper@2.0.0: - resolution: {integrity: sha512-V/ozejo+snzNf75i/a6iTmp71k+rlvqjE3+jYfimuMwR1tjNNRdtfno+NGNQB2An9bIAeqZnKhMDurAznHAdtA==} - dependencies: - heimdalljs-logger: 0.1.10 - transitivePeerDependencies: - - supports-color - dev: false - /broccoli-output-wrapper@3.2.5: resolution: {integrity: sha512-bQAtwjSrF4Nu0CK0JOy5OZqw9t5U0zzv2555EA/cF8/a8SLDTIetk9UgrtMVw7qKLKdSpOZ2liZNeZZDaKgayw==} engines: {node: 10.* || >= 12.*} @@ -6516,21 +6497,6 @@ packages: rimraf: 2.7.1 symlink-or-copy: 1.3.1 - /broccoli-plugin@3.1.0: - resolution: {integrity: sha512-7w7FP8WJYjLvb0eaw27LO678TGGaom++49O1VYIuzjhXjK5kn2+AMlDm7CaUFw4F7CLGoVQeZ84d8gICMJa4lA==} - engines: {node: 8.* || 10.* || >= 12.*} - dependencies: - broccoli-node-api: 1.7.0 - broccoli-output-wrapper: 2.0.0 - fs-merger: 3.2.1 - promise-map-series: 0.2.3 - quick-temp: 0.1.8 - rimraf: 2.7.1 - symlink-or-copy: 1.3.1 - transitivePeerDependencies: - - supports-color - dev: false - /broccoli-plugin@4.0.7: resolution: {integrity: sha512-a4zUsWtA1uns1K7p9rExYVYG99rdKeGRymW0qOCNkvDPHQxVi3yVyJHhQbM3EZwdt2E0mnhr5e0c/bPpJ7p3Wg==} engines: {node: 10.* || >= 12.*} @@ -7962,28 +7928,6 @@ packages: /ember-cli-get-component-path-option@1.0.0: resolution: {integrity: sha512-k47TDwcJ2zPideBCZE8sCiShSxQSpebY2BHcX2DdipMmBox5gsfyVrbKJWIHeSTTKyEUgmBIvQkqTOozEziCZA==} - /ember-cli-htmlbars@4.5.0: - resolution: {integrity: sha512-bYJpK1pqFu9AadDAGTw05g2LMNzY8xTCIqQm7dMJmKEoUpLRFbPf4SfHXrktzDh7Q5iggl6Skzf1M0bPlIxARw==} - engines: {node: 8.* || 10.* || >= 12.*} - dependencies: - '@ember/edition-utils': 1.2.0 - babel-plugin-htmlbars-inline-precompile: 3.2.0 - broccoli-debug: 0.6.5 - broccoli-persistent-filter: 2.3.1 - broccoli-plugin: 3.1.0 - common-tags: 1.8.2 - ember-cli-babel-plugin-helpers: 1.1.1 - fs-tree-diff: 2.0.1 - hash-for-dep: 1.5.1 - heimdalljs-logger: 0.1.10 - json-stable-stringify: 1.0.2 - semver: 6.3.0 - strip-bom: 4.0.0 - walk-sync: 2.2.0 - transitivePeerDependencies: - - supports-color - dev: false - /ember-cli-htmlbars@5.7.2: resolution: {integrity: sha512-Uj6R+3TtBV5RZoJY14oZn/sNPnc+UgmC8nb5rI4P3fR/gYoyTFIZSXiIM7zl++IpMoIrocxOrgt+mhonKphgGg==} engines: {node: 10.* || >= 12.*} @@ -8376,33 +8320,6 @@ packages: - '@babel/core' - supports-color - /ember-concurrency-ts@0.3.1(ember-concurrency@2.2.1): - resolution: {integrity: sha512-lE9uqPgK1Y9PN/0BJ5zE2a+h95izRCn6FCyt7qVV3012TlblTynsBaoUuAbN1T3KfzFsrJaXwsxzRbDjEde2Sw==} - engines: {node: 10.* || >= 12} - peerDependencies: - ember-concurrency: ^1.2.1 || ^2.0.0-rc.1 - dependencies: - ember-cli-babel: 7.26.11 - ember-cli-htmlbars: 4.5.0 - ember-concurrency: 2.2.1(@babel/core@7.21.3) - transitivePeerDependencies: - - supports-color - dev: false - - /ember-concurrency@2.2.1(@babel/core@7.21.3): - resolution: {integrity: sha512-a4283Yq+jimxqoD5YaxQu7cXePHKqkNQfsT4fs0nYTz5PYbUd6wzUtelp6k8R1JTNPwDdxyVvUgu7yYoC8Sk5A==} - engines: {node: 10.* || 12.* || 14.* || >= 16} - dependencies: - '@glimmer/tracking': 1.1.2 - ember-cli-babel: 7.26.11 - ember-cli-htmlbars: 5.7.2 - ember-compatibility-helpers: 1.2.6(@babel/core@7.21.3) - ember-destroyable-polyfill: 2.0.3(@babel/core@7.21.3) - transitivePeerDependencies: - - '@babel/core' - - supports-color - dev: false - /ember-concurrency@2.2.1(@babel/core@7.21.4): resolution: {integrity: sha512-a4283Yq+jimxqoD5YaxQu7cXePHKqkNQfsT4fs0nYTz5PYbUd6wzUtelp6k8R1JTNPwDdxyVvUgu7yYoC8Sk5A==} engines: {node: 10.* || 12.* || 14.* || >= 16} @@ -8427,6 +8344,7 @@ packages: transitivePeerDependencies: - '@babel/core' - supports-color + dev: true /ember-destroyable-polyfill@2.0.3(@babel/core@7.21.4): resolution: {integrity: sha512-TovtNqCumzyAiW0/OisSkkVK93xnVF4NRU6+FN0ubpfwEOpRrmM2RqDwXI6YAChCgSHON1cz0DfQStpA1Gjuuw==} @@ -9090,7 +9008,7 @@ packages: eslint-import-resolver-webpack: optional: true dependencies: - '@typescript-eslint/parser': 5.54.0(eslint@8.35.0)(typescript@4.8.2) + '@typescript-eslint/parser': 5.54.0(eslint@8.35.0)(typescript@5.0.3) debug: 3.2.7 eslint: 8.35.0 eslint-import-resolver-node: 0.3.7 @@ -9110,7 +9028,7 @@ packages: optional: true dependencies: '@babel/core': 7.21.4(supports-color@8.1.1) - '@babel/eslint-parser': 7.19.1(@babel/core@7.21.3)(eslint@8.35.0) + '@babel/eslint-parser': 7.19.1(@babel/core@7.21.4)(eslint@8.35.0) '@babel/plugin-proposal-decorators': 7.21.0(@babel/core@7.21.4) '@ember-data/rfc395-data': 0.0.4 ember-rfc176-data: 0.3.18 @@ -9175,7 +9093,7 @@ packages: '@typescript-eslint/parser': optional: true dependencies: - '@typescript-eslint/parser': 5.54.0(eslint@8.35.0)(typescript@4.8.2) + '@typescript-eslint/parser': 5.54.0(eslint@8.35.0)(typescript@5.0.3) array-includes: 3.1.6 array.prototype.flat: 1.3.1 array.prototype.flatmap: 1.3.1 @@ -15613,7 +15531,7 @@ packages: engines: {node: '>=12.20'} dev: true - file:ember-resources(@ember/test-waiters@3.0.2)(@glimmer/component@1.1.2)(@glimmer/tracking@1.1.2)(@glint/template@1.0.0-beta.3)(ember-async-data@1.0.1)(ember-concurrency@2.2.1)(ember-source@4.11.0): + file:ember-resources(@ember/test-waiters@3.0.2)(@glimmer/component@1.1.2)(@glimmer/tracking@1.1.2)(@glint/template@1.0.0-beta.3)(ember-async-data@1.0.1)(ember-source@4.11.0): resolution: {directory: ember-resources, type: directory} id: file:ember-resources name: ember-resources @@ -15644,7 +15562,6 @@ packages: '@glimmer/tracking': 1.1.2 '@glint/template': 1.0.0-beta.3 ember-async-data: 1.0.1(ember-source@4.11.0) - ember-concurrency: 2.2.1(@babel/core@7.21.3) ember-source: 4.11.0(@babel/core@7.21.3)(@glimmer/component@1.1.2)(webpack@5.72.1) transitivePeerDependencies: - supports-color diff --git a/test-app-ember-concurrency-2/.editorconfig b/test-app-ember-concurrency-2/.editorconfig new file mode 100644 index 000000000..c35a00240 --- /dev/null +++ b/test-app-ember-concurrency-2/.editorconfig @@ -0,0 +1,19 @@ +# EditorConfig helps developers define and maintain consistent +# coding styles between different editors and IDEs +# editorconfig.org + +root = true + +[*] +end_of_line = lf +charset = utf-8 +trim_trailing_whitespace = true +insert_final_newline = true +indent_style = space +indent_size = 2 + +[*.hbs] +insert_final_newline = false + +[*.{diff,md}] +trim_trailing_whitespace = false diff --git a/test-app-ember-concurrency-2/.ember-cli b/test-app-ember-concurrency-2/.ember-cli new file mode 100644 index 000000000..ee64cfed2 --- /dev/null +++ b/test-app-ember-concurrency-2/.ember-cli @@ -0,0 +1,9 @@ +{ + /** + Ember CLI sends analytics information by default. The data is completely + anonymous, but there are times when you might want to disable this behavior. + + Setting `disableAnalytics` to true will prevent any data from being sent. + */ + "disableAnalytics": false +} diff --git a/test-app-ember-concurrency-2/.eslintignore b/test-app-ember-concurrency-2/.eslintignore new file mode 100644 index 000000000..0e37383d9 --- /dev/null +++ b/test-app-ember-concurrency-2/.eslintignore @@ -0,0 +1,27 @@ +# Waiting on upstream fixes +*.gjs +*.gts + +# unconventional js +/blueprints/*/files/ +/vendor/ +/public/ + +# compiled output +/dist/ +/tmp/ + +# dependencies +/bower_components/ +/node_modules/ + +# misc +/coverage/ +!.* +.*/ +.eslintcache + +# ember-try +/.node_modules.ember-try/ +/bower.json.ember-try +/package.json.ember-try diff --git a/test-app-ember-concurrency-2/.eslintrc.js b/test-app-ember-concurrency-2/.eslintrc.js new file mode 100644 index 000000000..b8d71e83b --- /dev/null +++ b/test-app-ember-concurrency-2/.eslintrc.js @@ -0,0 +1,40 @@ +'use strict'; + +const { configs } = require('@nullvoxpopuli/eslint-configs'); + +const config = configs.ember(); + +module.exports = { + ...config, + overrides: [ + ...config.overrides, + { + files: ['**/*.ts'], + rules: { + /** + * This one is incorrectly parsed for now, because + * the rule doesn't understand decorators + */ + '@typescript-eslint/no-unused-vars': 'off', + + /** + * any can be useful + */ + '@typescript-eslint/no-explicit-any': 'off', + + /** + * Some compiler errors are not helpful + */ + '@typescript-eslint/ban-ts-comment': [ + 'error', + { + 'ts-ignore': 'allow-with-description', + 'ts-nocheck': 'allow-with-description', + 'ts-check': 'allow-with-description', + 'ts-expect-error': 'allow-with-description', + }, + ], + }, + }, + ], +}; diff --git a/test-app-ember-concurrency-2/.gitignore b/test-app-ember-concurrency-2/.gitignore new file mode 100644 index 000000000..7e0f7ddce --- /dev/null +++ b/test-app-ember-concurrency-2/.gitignore @@ -0,0 +1,26 @@ +# See https://help.github.com/ignore-files/ for more about ignoring files. + +# compiled output +/dist/ +/tmp/ + +# dependencies +/bower_components/ +/node_modules/ + +# misc +/.env* +/.pnp* +/.sass-cache +/.eslintcache +/connect.lock +/coverage/ +/libpeerconnection.log +/npm-debug.log* +/testem.log +/yarn-error.log + +# ember-try +/.node_modules.ember-try/ +/bower.json.ember-try +/package.json.ember-try diff --git a/test-app-ember-concurrency-2/.prettierignore b/test-app-ember-concurrency-2/.prettierignore new file mode 100644 index 000000000..8c855da54 --- /dev/null +++ b/test-app-ember-concurrency-2/.prettierignore @@ -0,0 +1,23 @@ +# unconventional js +/blueprints/*/files/ +/vendor/ +/public/ + +# compiled output +/dist/ +/tmp/ +CHANGELOG.md + +# dependencies +/bower_components/ +/node_modules/ + +# misc +/coverage/ +!.* +.eslintcache + +# ember-try +/.node_modules.ember-try/ +/bower.json.ember-try +/package.json.ember-try diff --git a/test-app-ember-concurrency-2/.prettierrc.js b/test-app-ember-concurrency-2/.prettierrc.js new file mode 100644 index 000000000..7665b0704 --- /dev/null +++ b/test-app-ember-concurrency-2/.prettierrc.js @@ -0,0 +1,30 @@ +'use strict'; + +module.exports = { + plugins: ['prettier-plugin-ember-template-tag'], + printWidth: 100, + singleQuote: true, + templateSingleQuote: false, + // this was required to make the VSCode + Prettier work correctly with