Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoteData: if status is >= 400, isError should be true #825

Closed
NullVoxPopuli opened this issue Mar 16, 2023 · 0 comments · Fixed by #827 or #864
Closed

RemoteData: if status is >= 400, isError should be true #825

NullVoxPopuli opened this issue Mar 16, 2023 · 0 comments · Fixed by #827 or #864
Labels
bug Something isn't working

Comments

@NullVoxPopuli
Copy link
Owner

https://github.com/NullVoxPopuli/ember-resources/blob/main/ember-resources/src/util/remote-data.ts#L126

Currently, isError is only true when fetch rejects. Which it won't for 404s against non-json apis.
@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Mar 16, 2023
@NullVoxPopuli NullVoxPopuli mentioned this issue Mar 16, 2023
Closed
10 tasks
@github-actions github-actions bot mentioned this issue Mar 16, 2023
Merged
@github-actions github-actions bot mentioned this issue Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@NullVoxPopuli