Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[The Last Witness] Fixes and improvements from testing with Glisp. #29

Open
4 tasks
NullCascade opened this issue Jun 4, 2019 · 1 comment
Open
4 tasks
Assignees

Comments

@NullCascade
Copy link
Owner

NullCascade commented Jun 4, 2019

  • Message box when time has run out for a crime.
  • Change time setting from game time to real time.
  • Fix issue where crimesByWitness list is nilled out prematurely.
  • Add description in MCM.
@NullCascade NullCascade self-assigned this Jun 4, 2019
@zackhasacat
Copy link

Some issues I found while implementing my own (simpler)version of this:

For the crimeWitnessed event, e.value is often 0 unless it's a theft. You need to use the crime type to get the right amount for the crime.

You need to account for followers, those following the player should not be a witness. You can check this with mobile.friendlyActors

No need for me to tell you this, just figured I'd put it here for posterity's sake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants