Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NuGet.PackageManagement: Rollback on mid-install failure such as IO or COMExceptions #48

Closed
deepakaravindr opened this issue Feb 9, 2015 · 4 comments
Closed

NuGet.PackageManagement: Rollback on mid-install failure such as IO or COMExceptions #48

deepakaravindr opened this issue Feb 9, 2015 · 4 comments
Assignees
@deepakaravindr
Labels
Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Type:Bug
Milestone
3.0.0-rc

Comments

@deepakaravindr
Copy link

No description provided.

@deepakaravindr deepakaravindr added the Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. label Feb 9, 2015
@deepakaravindr
Copy link
Author

Rollback on IO or COMExceptions. Also, Exceptions on failure rollback are just ignored. Need to consider that

@deepakaravindr deepakaravindr changed the title NuGet.PackageManagement: Exceptions on failure rollback are just ignored NuGet.PackageManagement: Rollback on IO or COMExceptions Feb 10, 2015
@deepakaravindr deepakaravindr modified the milestone: 3.0.0-rc Feb 10, 2015
@deepakaravindr deepakaravindr self-assigned this Feb 10, 2015
@deepakaravindr deepakaravindr modified the milestones: 3.0.0-beta, 3.0.0-rc Feb 11, 2015
@deepakaravindr deepakaravindr changed the title NuGet.PackageManagement: Rollback on IO or COMExceptions NuGet.PackageManagement: Rollback on mid-install failure such as IO or COMExceptions Feb 11, 2015
@deepakaravindr
Copy link
Author

Changing priority for this issue.
Newtonsoft.Json is not installable on JavaScript project systems. It will fail mid-way.
Hence, rolling back mid-way package install is needed

@deepakaravindr deepakaravindr added Priority:2 Issues for the current backlog. Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. and removed Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Priority:2 Issues for the current backlog. labels Feb 18, 2015
@deepakaravindr
Copy link
Author

Does not repro. Rollback feature covered this too

@deepakaravindr deepakaravindr modified the milestones: 3.0.0-beta, 3.0.0-rc-or-beta2 Feb 24, 2015
@deepakaravindr deepakaravindr added the Functionality:SDK The NuGet client packages published to nuget.org label Feb 24, 2015
@deepakaravindr
Copy link
Author

Does not repro. Tested by installing 'Microsoft.Net.Http' on Javascript Windows Phone application which will always fail in the middle. Verified that the installation is rolled back properly

@joelverhagen joelverhagen mentioned this issue Mar 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepakaravindr deepakaravindr

Labels
Functionality:SDK The NuGet client packages published to nuget.org Priority:2 Issues for the current backlog. Type:Bug
Projects
None yet
Milestone
3.0.0-rc
Development

No branches or pull requests
1 participant
@deepakaravindr