Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add msbuild extension point to better support auto-versioning helpers #11617

Open
xoofx opened this issue Feb 24, 2022 · 1 comment
Labels
Functionality:Pack Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:dotnet.exe Type:Feature

Comments

@xoofx
Copy link

xoofx commented Feb 24, 2022

NuGet Product(s) Involved

MSBuild.exe

The Elevator Pitch

Allow NuGet to provide a msbuild public extension point for calculating proper package id/version that would allow auto-versioning helpers to better integrate with NuGet (e.g MinVer).

Additional Context and Details

The problem is that today, most if not all auto-versioning helpers are unable to insert correctly into NuGet msbuild dependencies. See this issue adamralph/minver#675 for more details.

Proposal is to add a public target e.g NuGetPrepareForPackageIdAndVersion that would allow auto-versioning helpers to insert correctly into NuGet, just before _GetOutputItemsFromPack where we are actually requiring the PackageId / PackageVersion to be computed.

  <Target Name=NuGetPrepareForPackageIdAndVersion"/>

  <Target Name="_GetOutputItemsFromPack"
          DependsOnTargets="_GetAbsoluteOutputPathsForPack;NuGetPrepareForPackageIdAndVersion"
          Returns="@(_OutputPackItems)">
@nkolev92
Copy link
Member

_GetProjectVersion is an equivalent target today

@nkolev92 nkolev92 added the Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. label Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Functionality:Pack Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Product:dotnet.exe Type:Feature
Projects
None yet
Development

No branches or pull requests

5 participants