Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update status with info for wagmi #645

Closed
zoeyTM opened this issue Dec 10, 2023 · 1 comment · Fixed by #647
Closed

Update status with info for wagmi #645

zoeyTM opened this issue Dec 10, 2023 · 1 comment · Fixed by #647
Assignees

Comments

@zoeyTM
Copy link
Contributor

zoeyTM commented Dec 10, 2023

Add soureName and ABI info to the returned status info:

type GenericContractsDeclaration = {
  [deploymentId: string]: {
    chainId: number;
    [futureId: string]: {
      contractName: string;
      sourceName: string;
      address: Address;
      abi: Abi;
    };
  };
};
@zoeyTM zoeyTM moved this to Todo in Hardhat Ignition Dec 10, 2023
@zoeyTM zoeyTM moved this from Todo to In Progress in Hardhat Ignition Dec 10, 2023
@zoeyTM zoeyTM self-assigned this Dec 10, 2023
@zoeyTM
Copy link
Contributor Author

zoeyTM commented Dec 11, 2023

I decided against implementing this in status since the use cases seemed different enough to warrant a new task entirely. This is implemented in the new list task in #647

@zoeyTM zoeyTM moved this from In Progress to In Review in Hardhat Ignition Dec 11, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Hardhat Ignition Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant