From 97addf2aff58acd74a049cd06b81482337117c4c Mon Sep 17 00:00:00 2001 From: Maximilian Bosch Date: Fri, 1 Nov 2024 18:16:48 +0100 Subject: [PATCH 1/7] php83Extensions.couchbase: mark as broken ZHF #352882 Doesn't compile with PHP 8.3: https://hydra.nixos.org/build/276605925 We actually want to use the `couchbase-php-client`[1] repo. I briefly tried to package it, but given that I don't care a bit about this specific extension and it was far too annoying (vendored C++ libraries, .gitattributes removing CMake files from the GitHub tarball, a random CMake "package manager" is used) I decided to not bother. If nobody steps up, I'd suggest to throw it out when PHP 8.2 becomes EOL. [1] https://github.com/couchbase/couchbase-php-client/ --- pkgs/development/php-packages/couchbase/default.nix | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkgs/development/php-packages/couchbase/default.nix b/pkgs/development/php-packages/couchbase/default.nix index 2ed284fe6079bd..381ec3734243cf 100644 --- a/pkgs/development/php-packages/couchbase/default.nix +++ b/pkgs/development/php-packages/couchbase/default.nix @@ -5,6 +5,7 @@ libcouchbase, zlib, substituteAll, + php, }: let pname = "couchbase"; @@ -40,5 +41,6 @@ buildPecl { license = licenses.asl20; homepage = "https://docs.couchbase.com/php-sdk/current/project-docs/sdk-release-notes.html"; maintainers = teams.php.members; + broken = lib.versionAtLeast php.version "8.3"; }; } From a0034081298c792ea8fec56efd4eecec2152d707 Mon Sep 17 00:00:00 2001 From: Maximilian Bosch Date: Fri, 1 Nov 2024 18:32:56 +0100 Subject: [PATCH 2/7] php84Extensions.xdebug: mark as broken https://hydra.nixos.org/build/276609037 --- pkgs/development/php-packages/xdebug/default.nix | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkgs/development/php-packages/xdebug/default.nix b/pkgs/development/php-packages/xdebug/default.nix index 84ac38f6c4b85a..56fff995095e8b 100644 --- a/pkgs/development/php-packages/xdebug/default.nix +++ b/pkgs/development/php-packages/xdebug/default.nix @@ -1,6 +1,7 @@ { buildPecl, lib, + php, fetchFromGitHub, }: @@ -29,5 +30,6 @@ buildPecl { homepage = "https://xdebug.org/"; license = lib.licenses.php301; maintainers = lib.teams.php.members; + broken = lib.versionAtLeast php.version "8.4"; }; } From c54778b34570e8487dfc62def1291f69f89d3ae5 Mon Sep 17 00:00:00 2001 From: Maximilian Bosch Date: Fri, 1 Nov 2024 18:33:23 +0100 Subject: [PATCH 3/7] php84Extensions.swoole: mark as broken https://hydra.nixos.org/build/276557313 We have to await version 6.0 to support PHP 8.4. --- pkgs/development/php-packages/swoole/default.nix | 1 + 1 file changed, 1 insertion(+) diff --git a/pkgs/development/php-packages/swoole/default.nix b/pkgs/development/php-packages/swoole/default.nix index 6cc399be10dc39..7b52c838f47333 100644 --- a/pkgs/development/php-packages/swoole/default.nix +++ b/pkgs/development/php-packages/swoole/default.nix @@ -33,5 +33,6 @@ buildPecl { homepage = "https://www.swoole.com"; license = lib.licenses.asl20; maintainers = lib.teams.php.members; + broken = lib.versionAtLeast php.version "8.4"; }; } From d4f3913b1e6e36c4cd3ddd2092bf20ecd0218c26 Mon Sep 17 00:00:00 2001 From: Maximilian Bosch Date: Fri, 1 Nov 2024 18:33:54 +0100 Subject: [PATCH 4/7] php84Extensions.phalcon: mark as broken https://hydra.nixos.org/build/276605866 --- pkgs/development/php-packages/phalcon/default.nix | 1 + 1 file changed, 1 insertion(+) diff --git a/pkgs/development/php-packages/phalcon/default.nix b/pkgs/development/php-packages/phalcon/default.nix index b5d89ee6a0d269..e571c746f652f4 100644 --- a/pkgs/development/php-packages/phalcon/default.nix +++ b/pkgs/development/php-packages/phalcon/default.nix @@ -33,5 +33,6 @@ buildPecl rec { license = licenses.bsd3; homepage = "https://phalcon.io"; maintainers = teams.php.members ++ [ maintainers.krzaczek ]; + broken = lib.versionAtLeast php.version "8.4"; }; } From 4be7bdeb146790408f932ecfc19ef25f65ebaee3 Mon Sep 17 00:00:00 2001 From: Maximilian Bosch Date: Fri, 1 Nov 2024 18:34:14 +0100 Subject: [PATCH 5/7] php84Extensions.openswoole: mark as broken https://hydra.nixos.org/build/276670463 --- pkgs/development/php-packages/openswoole/default.nix | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkgs/development/php-packages/openswoole/default.nix b/pkgs/development/php-packages/openswoole/default.nix index b250db4a30038f..0a56b3f0e77487 100644 --- a/pkgs/development/php-packages/openswoole/default.nix +++ b/pkgs/development/php-packages/openswoole/default.nix @@ -5,6 +5,7 @@ valgrind, pcre2, fetchFromGitHub, + php, }: let @@ -34,5 +35,6 @@ buildPecl { You can use the sync or async, Coroutine API to write whole applications or create thousands of light weight Coroutines within one Linux process. ''; maintainers = teams.php.members; + broken = lib.versionAtLeast php.version "8.4"; }; } From 11c20b26cccb3dd1c1d2326fca70bc9859e01a99 Mon Sep 17 00:00:00 2001 From: Maximilian Bosch Date: Fri, 1 Nov 2024 19:13:57 +0100 Subject: [PATCH 6/7] php84Extensions.soap: skip tests See https://hydra.nixos.org/build/275613910 The issue that symbols from `session.so` cannot be loaded doesn't happen when building a PHP with ext-soap enabled. To me it seems as if PHP just doesn't find it on runtime. My current hypothesis is that this is because ext-soap now depends on ext-session[1]. [1] https://github.com/php/php-src/commit/c7797fc8c0503c18791fd651f5ebdd7164b4bc48 --- pkgs/top-level/php-packages.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/top-level/php-packages.nix b/pkgs/top-level/php-packages.nix index 0d864e837ff253..0307e5185a1d32 100644 --- a/pkgs/top-level/php-packages.nix +++ b/pkgs/top-level/php-packages.nix @@ -663,7 +663,7 @@ in { # Some tests are causing issues in the Darwin sandbox with issues # such as # Unknown: php_network_getaddresses: getaddrinfo for localhost failed: nodename nor servname provided - doCheck = !stdenv.hostPlatform.isDarwin; + doCheck = !stdenv.hostPlatform.isDarwin && lib.versionOlder php.version "8.4"; internalDeps = [ php.extensions.session ]; patches = lib.optionals (lib.versions.majorMinor php.version == "8.1") [ # Fix tests with libxml2 2.12 From 8236f19edb88f11949d250ae9d8e6d23d6432502 Mon Sep 17 00:00:00 2001 From: Maximilian Bosch Date: Fri, 1 Nov 2024 19:16:35 +0100 Subject: [PATCH 7/7] phpPackages.psysh: update hashes I originally wanted to investigate what went wrong here, but I guess that the tag just got force-pushed. See https://hydra.nixos.org/build/276639542 --- pkgs/development/php-packages/psysh/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/development/php-packages/psysh/default.nix b/pkgs/development/php-packages/psysh/default.nix index e30fc51cfd8bc9..ffa163168286f5 100644 --- a/pkgs/development/php-packages/psysh/default.nix +++ b/pkgs/development/php-packages/psysh/default.nix @@ -19,7 +19,7 @@ let composerLock = fetchurl { name = "composer.lock"; url = "https://github.com/bobthecow/psysh/releases/download/v${version}/composer-v${version}.lock"; - hash = "sha256-ur6mzla3uXeFL6aEHAPdpxGdvcgzOgTLW/CKPbNqeCg="; + hash = "sha256-PQDWShzvTY8yF+OUPVJAV0HMx0/KnA03TDhZUM7ppXw="; }; in php.buildComposerProject2 (finalAttrs: { @@ -45,7 +45,7 @@ php.buildComposerProject2 (finalAttrs: { composer update --lock --no-install ''; - vendorHash = "sha256-mW276lzOTCY68EnvSVR+tD+gh3Y61GrWchVJHDZ4dpg="; + vendorHash = "sha256-tKy2A3dGGmZZzZF0JxtG6NYMfG/paQsuxAO1y3GfCsA="; }; meta = {