Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nvidia: clean up and add dynamic boost #244060

Merged
merged 2 commits into from
Aug 10, 2023
Merged

nixos/nvidia: clean up and add dynamic boost #244060

merged 2 commits into from
Aug 10, 2023

Conversation

Gerg-L
Copy link
Contributor

@Gerg-L Gerg-L commented Jul 17, 2023

Description of changes

Closes: #211300
The NVIDIA module was in need of some TLC so I cleaned it up and re-formatted.

the only actual change in the first commit should be the removal of the isDeprecated = str: (hasPrefix "nvidia" str) && (str != "nvidia"); check from: #99323
(2 years old)
and the nvidia prime rename from: #66601
(4 years old)

The second commit is the addition of NVIDIA Dynamic Boost from #211300

Some more testing would be appreciated

Questions: should I be using lib.mdDoc and lib.options.mkPackageOptionMD here or not?

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 17, 2023
@Gerg-L Gerg-L changed the title Nvidia dynamic boost nixos/nvidia: add dynamic boost Jul 17, 2023
@Gerg-L Gerg-L changed the title nixos/nvidia: add dynamic boost nixos/nvidia: clean up and add dynamic boost Jul 17, 2023
@ofborg ofborg bot requested review from Kiskae and jonringer July 17, 2023 22:26
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500 labels Jul 17, 2023
@Gerg-L Gerg-L force-pushed the nvidiaDynamicBoost branch from ea9ac67 to 1d4f090 Compare July 17, 2023 23:39
@jian-lin
Copy link
Contributor

Questions: should I be using lib.mdDoc and lib.options.mkPackageOptionMD here or not?

I think you should use the MD variants because it makes backporting changes to the stable much easier and has no harm.

@jian-lin jian-lin mentioned this pull request Jul 18, 2023
Closed
13 tasks
@Gerg-L Gerg-L force-pushed the nvidiaDynamicBoost branch from 1d4f090 to 45539dd Compare July 18, 2023 20:51
@Gerg-L
Copy link
Contributor Author

Gerg-L commented Jul 18, 2023

I think you should use the MD variants because it makes backporting changes to the stable much easier and has no harm.

Alright, done.

@cch000
Copy link
Contributor

cch000 commented Aug 3, 2023

Any updates?

Kiskae
Kiskae suggested changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@Kiskae Kiskae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the required version it looks good to me, although going through this has made me realize the nvidia package itself probably needs a rewrite at some point.

@Gerg-L
Copy link
Contributor Author

Gerg-L commented Aug 3, 2023

Other than the required version it looks good to me, although going through this has made me realize the nvidia package itself probably needs a rewrite at some point.

Most definitely, I was thinking of rewriting all of services.xserver and all the Wayland compositor modules.

I'm trying to get to it before 22.11 is released

@Gerg-L Gerg-L force-pushed the nvidiaDynamicBoost branch from 45539dd to 4ca2a16 Compare August 3, 2023 13:32
@ofborg ofborg bot requested a review from Kiskae August 3, 2023 14:10
@fpletz
Copy link
Member

fpletz commented Aug 10, 2023

I'm trying to get to it before 22.11 is released

Please send me a copy of the time machine you're using. As mine has been in the shop for aeons I'm not able to fix the bad code I wrote for 17.09. 😆

@fpletz fpletz merged commit 9c85697 into NixOS:master Aug 10, 2023
@Gerg-L
Copy link
Contributor Author

Gerg-L commented Aug 10, 2023

I'm trying to get to it before 22.11 is released

Please send me a copy of the time machine you're using. As mine has been in the shop for aeons I'm not able to fix the bad code I wrote for 17.09. 😆

Fat fingers lol, meant 23.11

@Gerg-L Gerg-L deleted the nvidiaDynamicBoost branch August 10, 2023 21:18
This was referenced Mar 25, 2024
Merged
Merged
fpletz pushed a commit that referenced this pull request Mar 26, 2024
@ncfavier
nixos/nvidia: update manual
fb613a3 
Remove the `nvidiaLegacy*` video drivers from the manual: not only are
they deprecated, their deprecation notice was removed in
#244060.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kiskae Kiskae Kiskae approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gerg-L @jian-lin @cch000 @fpletz @Kiskae