nixos/nvidia: add Dynamic Boost support #211300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
NickCao
reviewed
Jan 18, 2023
Comment on lines
+194
to
+195
| mkdir -p $bin/share/dbus-1/system.d | ||
| cp nvidia-dbus.conf $bin/share/dbus-1/system.d |
There was a problem hiding this comment.
Suggested change
| mkdir -p $bin/share/dbus-1/system.d | |
| cp nvidia-dbus.conf $bin/share/dbus-1/system.d | |
| install -Dm644 nvidia-dbus.conf $bin/share/dbus-1/system.d/nvidia-dbus.conf |
|
Any updates? |
|
Frankly, I didn't have enough time and interest to seek a reviewer's attention for this PR. However, I'm still somewhat interested in using the feature, so I may rebase and try again over the next week. |
|
@piousdeer dbus is enabled by systemd by default so Sources: |
12 tasks
|
FYI, #244060 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This adds a new option,
hardware.nvidia.dynamicBoost.enable, according to Nvidia's docs. Also, a few descriptions are changed to fix a typo and improve consistency.Dynamic Boost balances power between the CPU and the GPU for improved performance on supported laptops using the nvidia-powerd daemon. Tested on my RTX 3060 laptop, enabling this option results in the GPU being able to draw up to 95W instead of 80W.
Some questions:
$bin/sharethe better place to put the dbus config into? Does it matter?services.dbus.packageschecks bothetcandshare, and Nvidia's docs sayetc, but I went withsharebecause it already exists.services.dbus.packagesdon't also includeservices.dbus.enable = true.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes