Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helix: init at 0.3.0 #126208

Merged
merged 2 commits into from
Jun 30, 2021
Merged

helix: init at 0.3.0 #126208

merged 2 commits into from
Jun 30, 2021

Conversation

yusdacra
Copy link
Member

@yusdacra yusdacra commented Jun 8, 2021 •
edited
Loading

Motivation for this change

Adds helix editor. Currently seems to not build because of failing tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Artturin
Artturin requested changes Jun 9, 2021
View reviewed changes
@archseer archseer mentioned this pull request Jun 10, 2021
Merged
@yusdacra yusdacra force-pushed the add-helix branch 2 times, most recently from 13c044d to d28ba64 Compare June 13, 2021 14:42
@yusdacra yusdacra changed the title helix: init at 0.0.10 helix: init at 0.2.0 Jun 13, 2021
@archseer archseer mentioned this pull request Jun 14, 2021
Closed
@yusdacra yusdacra changed the title helix: init at 0.2.0 helix: init at 0.3.0 Jun 27, 2021
@yusdacra yusdacra marked this pull request as ready for review June 27, 2021 18:13
dotlambda
dotlambda requested changes Jun 28, 2021
View reviewed changes
@SuperSandro2000 SuperSandro2000 merged commit a3274dc into NixOS:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@ashkitten ashkitten ashkitten left review comments

@dotlambda dotlambda dotlambda requested changes

@Artturin Artturin Artturin requested changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yusdacra @archseer @dotlambda @SuperSandro2000 @ashkitten @Artturin