You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
None of the fetchers that I've looked at so far support overriding the fetch arguments. This is rather annoying when trying to override derivations that use them, as I need to repeat the original fetcher in my override instead of merely overriding the arguments I want to change.
This could be solved by wrapping all of the fetchers with lib.makeOverridable. I don't know what the performance implications are of turning these functions into functors instead, but I would hope it's negligible.
I was going to simply submit a PR for this, but we have a lot more fetchers than I thought, and I didn't want to do that work unless I knew it would be accepted.
As an example, if I want to change the version of ffsend, right now I have to write
This is repeating stuff that I really shouldn't have to do here, including the fact that ffsend uses GitLab instead of GitHub, and the repo/owner. I should be able to instead write
Describe the bug
None of the fetchers that I've looked at so far support overriding the fetch arguments. This is rather annoying when trying to override derivations that use them, as I need to repeat the original fetcher in my override instead of merely overriding the arguments I want to change.
This could be solved by wrapping all of the fetchers with
lib.makeOverridable
. I don't know what the performance implications are of turning these functions into functors instead, but I would hope it's negligible.I was going to simply submit a PR for this, but we have a lot more fetchers than I thought, and I didn't want to do that work unless I knew it would be accepted.
As an example, if I want to change the version of
ffsend
, right now I have to writeThis is repeating stuff that I really shouldn't have to do here, including the fact that ffsend uses GitLab instead of GitHub, and the repo/owner. I should be able to instead write
And with the
mkDerivation
changes proposed in #94198 that would shrink even further toThe text was updated successfully, but these errors were encountered: