Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix-synapse wants prometheus-client < 0.4.0, we have 0.4.2 on master branch #52621

Closed
7c6f434c opened this issue Dec 21, 2018 · 5 comments
Closed

Comments

@7c6f434c
Copy link
Member

Issue description

The freshest currently released upstream Matrix Synapse version is 0.34.0 (we have 0.33.9), and it still wants prometheus-client with version <0.4.0. We currently have exactly one version of pythonPackages.prometheus_client, and it is 0.4.2. What would be the best way for updating matrix-synapse? A privately cloned prometheus-client expression (which will probably then fall even more out of date than needed, but Matrix seems to still support quite old versions anyway)? Or should I try to remove the constraint and see if something clearly breaks?

@FRidh I am not fully sure from reading NixOS/rfcs#24 which option is better.

Steps to reproduce

nix build matrix-synapse

@bachp
Copy link
Member

bachp commented Dec 21, 2018

There is already in issue on the synapse repository matrix-org/synapse#4221

@7c6f434c
Copy link
Member Author

Oh well, I guess it replaces the second option «with break the pin and get breakage», so for this specific case there is a natural choice. Thanks.

@bachp
Copy link
Member

bachp commented Dec 21, 2018

@7c6f434c Will you come up with a PR to fix this issue?

@7c6f434c
Copy link
Member Author

No.

@7c6f434c
Copy link
Member Author

35efbed and its parent must have been pushed before your comment…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants