-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging is unmergeable #4781
Comments
Fixed by a9c5303. |
@peti you merged master into staging, but I have yet to see staging nixos tests pass in hydra. |
All test failures I saw were due to a failing |
That's the latest failure, but see earlier failures. |
I have not seen any other failure that looked like a fixable issue (i.e. I saw test failures because the network went down or some other temporary thing). If you have any specific test failure in mind, please don't hesitate to share a specific URL that shows the problem. Also, please feel free re-open the issue at your discretion if you feel that's the best course of action. |
@peti yes all those network failures, but on nixos/trunk-combined network works. If you note, it only happens for installer tests and containers. It must be something that went into staging and broke those tests specifically. |
Reopening until I see staging tests pass :) |
We should probably back out the fontconfig changes in the staging branch until we get #4410 sorted out. |
Well, I think it will be better to just do the fontconfig change @edolstra suggested. I'm confident I can do it this week, unless someone does it first, of course. (It's to save additional rebuild, as Hydra has problems to catch up, which probably slows down 14.11 stabilization.) I don't think the fontconfig changes should cause any of these problems you discuss here, as I'm running with it for weeks on my main desktop, and we really do want the new fontconfig in 14.11 anyway (AFAIK). |
Most NixOS tests are OK now. |
@vcunat not really. Most of tests also passed before. The problem is the installer. I've merged staging into master locally and the installer tests hang on shutdown because they cannot umount the iso:
@edolstra recently fixed another issue with /dev/root, but there's still some other issue left to be fixed. |
@lethalman The installer tests are all fine (except the rebuildCD thingy): http://hydra.nixos.org/jobset/nixos/staging I believe the shutdown problem is a pre-existing condition. |
@edolstra on staging yes maybe, but when merging staging into master, they fail. Btw let's merge? |
Staging was merged. |
For the 14.11 I'm sure people wants staging stuff into master. This is not possible as tests don't pass since a lot of time: http://hydra.nixos.org/jobset/nixos/staging
The text was updated successfully, but these errors were encountered: