Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging is unmergeable #4781

Closed
lucabrunox opened this issue Nov 2, 2014 · 15 comments
Closed

Staging is unmergeable #4781

lucabrunox opened this issue Nov 2, 2014 · 15 comments
Milestone

Comments

@lucabrunox
Copy link
Contributor

For the 14.11 I'm sure people wants staging stuff into master. This is not possible as tests don't pass since a lot of time: http://hydra.nixos.org/jobset/nixos/staging

@lucabrunox lucabrunox added this to the 14.11 milestone Nov 2, 2014
@peti
Copy link
Member

peti commented Nov 2, 2014

Fixed by a9c5303.

@peti peti closed this as completed Nov 2, 2014
@lucabrunox
Copy link
Contributor Author

@peti you merged master into staging, but I have yet to see staging nixos tests pass in hydra.

@peti
Copy link
Member

peti commented Nov 2, 2014

All test failures I saw were due to a failing libgpg-error-1.17 build. That issue is now fixed. Still, it's a good idea have a look at the tests anyway and maybe re-open this issue if there's still significant breakage.

@lucabrunox
Copy link
Contributor Author

That's the latest failure, but see earlier failures.

@peti
Copy link
Member

peti commented Nov 2, 2014

I have not seen any other failure that looked like a fixable issue (i.e. I saw test failures because the network went down or some other temporary thing). If you have any specific test failure in mind, please don't hesitate to share a specific URL that shows the problem. Also, please feel free re-open the issue at your discretion if you feel that's the best course of action.

@lucabrunox
Copy link
Contributor Author

@peti yes all those network failures, but on nixos/trunk-combined network works. If you note, it only happens for installer tests and containers. It must be something that went into staging and broke those tests specifically.
It's not a transient failure.

@lucabrunox
Copy link
Contributor Author

Reopening until I see staging tests pass :)

@lucabrunox lucabrunox reopened this Nov 2, 2014
@edolstra
Copy link
Member

edolstra commented Nov 3, 2014

We should probably back out the fontconfig changes in the staging branch until we get #4410 sorted out.

@lucabrunox
Copy link
Contributor Author

Also I've built staging simple installer successfully. Maybe after this nixpkgs iteration it won't fail I hope. PInging @vcunat to ack the revert of #4410 , when I have time I'm going to work on the @edolstra proposal.

@vcunat
Copy link
Member

vcunat commented Nov 3, 2014

Well, I think it will be better to just do the fontconfig change @edolstra suggested. I'm confident I can do it this week, unless someone does it first, of course. (It's to save additional rebuild, as Hydra has problems to catch up, which probably slows down 14.11 stabilization.)

I don't think the fontconfig changes should cause any of these problems you discuss here, as I'm running with it for weeks on my main desktop, and we really do want the new fontconfig in 14.11 anyway (AFAIK).

@vcunat
Copy link
Member

vcunat commented Nov 12, 2014

Most NixOS tests are OK now.

@vcunat vcunat closed this as completed Nov 12, 2014
@lucabrunox
Copy link
Contributor Author

@vcunat not really. Most of tests also passed before. The problem is the installer. I've merged staging into master locally and the installer tests hang on shutdown because they cannot umount the iso:

machine# [  308.300879] systemd[1]: Stopping Remote File Systems.
machine# [  308.302528] systemd[1]: Stopped target Remote File Systems.
machine# [  308.303895] systemd[1]: iso.mount mount process exited, code=exited status=32
machine# [  308.305260] systemd[1]: Failed unmounting /iso.
machine# [  308.306320] systemd[1]: nix-store.mount mount process exited, code=exited status=32
machine# [  308.307533] systemd[1]: Failed unmounting /nix/store.
machine# [  308.308550] systemd[1]: Stopped Load/Save Random Seed.
machine# [  308.309546] systemd[1]: Stopped Update UTMP about System Boot/Shutdown.
machine# [  308.310622] systemd[1]: Starting Unmount All Filesystems.
machine# [  308.312210] systemd[1]: Reached target Unmount All Filesystems.
machine# [  308.313300] systemd[1]: Stopping Local File Systems (Pre).
machine# [  308.314399] systemd[1]: Stopped target Local File Systems (Pre).
machine# [  308.317624] systemd[1]: Stopping Remount Root and Kernel File Systems...
machine# [  308.322787] systemd[1]: Stopped Remount Root and Kernel File Systems.
machine# [  308.330416] systemd[1]: Stopping Create Static Device Nodes in /dev...
machine# [  308.336352] systemd[1]: Stopped Create Static Device Nodes in /dev.[  308.339857] s
ystemd-shutdown[1]: Sending SIGTERM to remaining processes...

@edolstra recently fixed another issue with /dev/root, but there's still some other issue left to be fixed.

@lucabrunox lucabrunox reopened this Nov 13, 2014
@edolstra
Copy link
Member

@lethalman The installer tests are all fine (except the rebuildCD thingy): http://hydra.nixos.org/jobset/nixos/staging

I believe the shutdown problem is a pre-existing condition.

@lucabrunox
Copy link
Contributor Author

@edolstra on staging yes maybe, but when merging staging into master, they fail. Btw let's merge?

@vcunat
Copy link
Member

vcunat commented Nov 14, 2014

Staging was merged.

@vcunat vcunat closed this as completed Nov 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants