Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure: ripgrep-all #350367

Closed
Samasaur1 opened this issue Oct 21, 2024 · 5 comments · Fixed by #350768
Closed

Build failure: ripgrep-all #350367

Samasaur1 opened this issue Oct 21, 2024 · 5 comments · Fixed by #350768
Labels
0.kind: build failure A package fails to build 6.topic: darwin Running or building packages on Darwin

Comments

@Samasaur1
Copy link
Member

Steps To Reproduce

Steps to reproduce the behavior:

  1. build ripgrep-all

Build log

https://gist.github.com/Samasaur1/3a9b67fdcca24e4ccede859cdd480153

Additional context

Add any other context about the problem here.

Notify maintainers

@zaninime @Ma27

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix run nixpkgs#nix-info -- -m
 - system: `"aarch64-darwin"`
 - host os: `Darwin 23.6.0, macOS 14.6.1`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.18.8`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/nix/store/60sn02zhawl3kwn0r515zff3h6hg6ydz-source`

Add a 👍 reaction to issues you find important.

@Samasaur1 Samasaur1 added 6.topic: darwin Running or building packages on Darwin 0.kind: build failure A package fails to build labels Oct 21, 2024
@NotAShelf
Copy link
Member

Looks like this is a Darwin exclusive issue - ripgrep-all builds fine on x86_64 and aarch64 Linux.

@taranlu-houzz
Copy link

Same issue here, also on macOS.

@deejayem
Copy link
Member

Strange - I checked out the source code, followed the instructions in https://github.com/phiresky/ripgrep-all?tab=readme-ov-file#nix-and-direnv , and cargo test (and cargo build) work fine.

I also changed default.nix in nixpkgs to use the latest revision from github and updated Cargo.lock, but when I run nix-build -A ripgrep-all I still get the same Cannot wrap '/nix/store/7hdannw819llmsz2l4hdgppsjc3i0p48-ripgrep-all-0.10.6/bin/rga-fzf-open.dSYM' because it is not an executable file error shown in the build log above.

@Ma27
Copy link
Member

Ma27 commented Oct 23, 2024

Does anybody have an idea how the rga-fzf-open.dSYM ends up in there? And is this even needed or just an artifact that ends up there for no real reason?

If the latter is actually the case, we could also just rm it before creating the wrappers.

@zaninime
Copy link
Contributor

Created #350768 to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: build failure A package fails to build 6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants