Build failure: sunshine

[nyawox]

Steps To Reproduce

Steps to reproduce the behavior:

1. Update flake.lock to latest nixos-unstable
2. services.sunshine.enable = true;

Build log

please ignore the indentation:)

       last 25 log lines:
       >       |
       > In file included from /build/source/src/upnp.cpp:5:
       > /nix/store/vmzxminj8mwfw81whay2524c4b6w321q-miniupnpc-2.2.8/include/miniupnpc/miniupnpc.h:122:1: note: declared here
       >   122 | UPNP_GetValidIGD(struct UPNPDev * devlist,
       >       | ^~~~~~~~~~~~~~~~
       > /build/source/src/upnp.cpp: In member function 'void upnp::deinit_t::upnp_thread_proc()':
       > /build/source/src/upnp.cpp:334: error: too few arguments to function 'int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDdatas*, char*, int, char*, int)'
       >   334 |         auto status = UPNP_GetValidIGD(device.get(), &urls.el, &data, lan_addr.data(), lan_addr.size());
       >       |
       > /nix/store/vmzxminj8mwfw81whay2524c4b6w321q-miniupnpc-2.2.8/include/miniupnpc/miniupnpc.h:122:1: note: declared here
       >   122 | UPNP_GetValidIGD(struct UPNPDev * devlist,
       >       | ^~~~~~~~~~~~~~~~
       > [ 68%] Building C object CMakeFiles/sunshine.dir/generated-src/xdg-output-unstable-v1.c.o
       > [ 70%] Building C object CMakeFiles/sunshine.dir/generated-src/wlr-export-dmabuf-unstable-v1.c.o
       > [ 72%] Building CXX object CMakeFiles/sunshine.dir/src/platform/linux/wlgrab.cpp.o
       > /build/source/src/upnp.cpp: At global scope:
       > /build/source/src/upnp.cpp:47: warning: 'std::string_view upnp::status_string(int)' defined but not used [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-function-Wunused-function8;;]
       >    47 |   status_string(int status) {
       >       |
       > [ 75%] Building CXX object CMakeFiles/sunshine.dir/src/platform/linux/wayland.cpp.o
       > make[3]: *** [CMakeFiles/sunshine.dir/build.make:104: CMakeFiles/sunshine.dir/src/upnp.cpp.o] Error 1
       > make[3]: *** Waiting for unfinished jobs....
       > make[2]: *** [CMakeFiles/Makefile2:191: CMakeFiles/sunshine.dir/all] Error 2
       > make[1]: *** [CMakeFiles/Makefile2:198: CMakeFiles/sunshine.dir/rule] Error 2
       > make: *** [Makefile:190: sunshine] Error 2

Additional context

I think it's the same issue as #326140, UPNP_GetValidIGD expects more arguments

Notify maintainers

@devusb

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

~ 
󰘧 nix-shell -p nix-info --run "nix-info -m"
fetching path input 'path:/nix/store/dk2rpyb6ndvfbf19bkb2plcz5y3k8i5v-source'
warning: Nix search path entry '/nix/var/nix/profiles/per-user/root/channels' does not exist, ignoring
 - system: `"x86_64-linux"`
 - host os: `Linux 6.9.7, NixOS, 24.11 (Vicuna), 24.11.20240703.9f4128e`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Lix, like Nix) 2.90.0-rc1`
 - nixpkgs: `/nix/store/dk2rpyb6ndvfbf19bkb2plcz5y3k8i5v-source`

---

Add a 👍 reaction to issues you find important.

[eclairevoyant]

can you retest with #326057 applied? (e.g. as an overlay)

[devusb]

#326057 should solve it for 0.23.1 -- upstream has already fixed compatibility with new miniupnpc in LizardByte/Sunshine#2782 as well, but the patch is not directly compatible with 0.23.1 -- next release should be able to work with new and old miniupnpc.

[nyawox]

my bad, I missed that PR. and yes, it works after applying. I should close this issue.