Build failure: flycast

[nonetrix]

Steps To Reproduce

Steps to reproduce the behavior:

1. Build flycast on nixpkgs unstable
2. Observe

Build log

♥ ❯ sudo nixos-rebuild switch --flake .                                  
[sudo] password for noah: 
warning: Git tree '/home/noah/Documents/Projects/nix/nixdots' is dirty
building the system configuration...
warning: Git tree '/home/noah/Documents/Projects/nix/nixdots' is dirty
error: builder for '/nix/store/wxablip7s70qimfqacz2lddgba2vidfp-flycast-2.3.2.drv' failed with exit code 2;
       last 10 log lines:
       > make[2]: *** Waiting for unfinished jobs....
       > /build/source/core/network/picoppp.cpp: In function 'void check_dns_entries()':
       > /build/source/core/network/picoppp.cpp:754:68: warning: taking address of packed member of 'pico_ip4' may result in an unaligned pointer value [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Waddress-of-packed-member-Waddress-of-packed-member8;;]
       >   754 |                         pico_string_to_ipv4(RESOLVER1_OPENDNS_COM, &tmpdns.addr);
       >       |                                                                    ^~~~~~~~~~~~
       > /build/source/core/network/picoppp.cpp:760:68: warning: taking address of packed member of 'pico_ip4' may result in an unaligned pointer value [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Waddress-of-packed-member-Waddress-of-packed-member8;;]
       >   760 |                         pico_string_to_ipv4(RESOLVER1_OPENDNS_COM, &tmpdns.addr);
       >       |                                                                    ^~~~~~~~~~~~
       > make[1]: *** [CMakeFiles/Makefile2:410: CMakeFiles/flycast.dir/all] Error 2
       > make: *** [Makefile:136: all] Error 2
       For full logs, run 'nix log /nix/store/wxablip7s70qimfqacz2lddgba2vidfp-flycast-2.3.2.drv'.
error: 1 dependencies of derivation '/nix/store/nas8a1wd7yi73lfr9323pc536y8rszfr-system-path.drv' failed to build
error (ignored): error: cannot unlink '/tmp/nix-build-hyprland-0.41.2+date=2024-07-10_e104481.drv-1/build/source/build/CMakeFiles/Hyprland.dir/src': Directory not empty
error: 1 dependencies of derivation '/nix/store/0camqqnriyhz3rwcrs81700nqv53slaa-nixos-system-nixos-24.11.20240709.feb2849.drv' failed to build

Fullish:
https://gist.github.com/nonetrix/5a65c8ff04b468045159deff0c6b57f4
(Note: slightly truncated, shouldn't matter because just duplicated lines pretty much. I only know how to run nix log and copy and paste from terminal. Why is there no instructions on how to just cat the log without a pager here? Issue template is unclear)

Additional context

None that I can think of

Notify maintainers

None listed :(

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

♥ ❯ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.9.8, NixOS, 24.11 (Vicuna), 24.11.20240708.655a58a`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.4`
 - channels(root): `"home-manager, nixos"`
 - nixpkgs: `/nix/store/yzkx7gx2cn73dh3c7zg5rvgkp3yli1cd-source`

---

Add a 👍 reaction to issues you find important.

[eclairevoyant]

actual error:

/build/source/core/network/miniupnp.cpp:46:33: error: too few arguments to function 'int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDdatas*, char*, int, char*, int)'
   46 |         error = UPNP_GetValidIGD(devlist, &urls, &data, lanAddress, sizeof(lanAddress));
      |                 ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /build/source/core/network/miniupnp.cpp:21:
/nix/store/vmzxminj8mwfw81whay2524c4b6w321q-miniupnpc-2.2.8/include/miniupnpc/miniupnpc.h:122:1: note: declared here
  122 | UPNP_GetValidIGD(struct UPNPDev * devlist,
      | ^~~~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/flycast.dir/build.make:2582: CMakeFiles/flycast.dir/core/network/miniupnp.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....

can you retest with #326057 applied? (e.g. as an overlay)

[nonetrix]

I'm not exactly sure how to do that, can you just point me in the right direction? Sorry

[emilazy]

This is already fixed on master, but #326402 will fix the specific compilation error here too. It should work fine in the next channel update.