doas does not cross-compile

[dsalaza4]

Describe the bug

doas command does not build on aarch64-multiplatform and aarch64-multiplatform-musl.

Steps To Reproduce

nix-shell -p pkgsCross.aarch64-multiplatform.doas
...
building
build flags: SHELL=/nix/store/9zm6br2ri10a0b71dll2wrim5bnhg6b6-bash-5.1-p16/bin/bash
yacc  parse.y
/nix/store/9zm6br2ri10a0b71dll2wrim5bnhg6b6-bash-5.1-p16/bin/bash: line 1: yacc: command not found
make: *** [<builtin>: parse.c] Error 127
error: builder for '/nix/store/qgi06mxsqjn08rnvklkh0q1ckwrpwzxf-doas-aarch64-unknown-linux-gnu-6.8.2.drv' failed with exit code 2;
       last 10 log lines:
       > Checking for login_cap_h ...              no.
       > Checking for __attribute__ ...             yes.
       > Checking for pam_appl_h ...               yes.
       > Using auth method                 pam.
       > Using persist method                      timestamp.
       > building
       > build flags: SHELL=/nix/store/9zm6br2ri10a0b71dll2wrim5bnhg6b6-bash-5.1-p16/bin/bash
       > yacc  parse.y
       > /nix/store/9zm6br2ri10a0b71dll2wrim5bnhg6b6-bash-5.1-p16/bin/bash: line 1: yacc: command not found
       > make: *** [<builtin>: parse.c] Error 127
       For full logs, run 'nix log /nix/store/qgi06mxsqjn08rnvklkh0q1ckwrpwzxf-doas-aarch64-unknown-linux-gnu-6.8.2.drv'.

Expected behavior

doas should compile properly for aarch64-multiplatform and aarch64-multiplatform-musl.

Notify maintainers

@cole-h @cstrahan

Metadata

nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.2.8, NixOS, 23.05 (Stoat), 23.05.20230328.49079a1`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.14.1`
 - channels(nixos): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

[jpverde]

Executing nix-shell -p doas on a Macbook Pro M1 i get the same error

clang -I. -Ilibopenbsd -O2 -Wall -Wextra -D__darwin__    -c -o pam.o pam.c
clang -I. -Ilibopenbsd -O2 -Wall -Wextra -D__darwin__    -c -o timestamp.o timestamp.c
timestamp.c:65:10: fatal error: 'sys/vfs.h' file not found
#include <sys/vfs.h>
         ^~~~~~~~~~~
1 error generated.
make: *** [<builtin>: timestamp.o] Error 1
rm parse.c
error: builder for '/nix/store/66fvlrxqaazlazxybp2cp4g1v336gac5-doas-6.8.2.drv' failed with exit code 2;
       last 10 log lines:
       > clang -I. -Ilibopenbsd -O2 -Wall -Wextra -D__darwin__    -c -o libopenbsd/bsd-setres_id.o libopenbsd/bsd-setres_id.c
       > clang -I. -Ilibopenbsd -O2 -Wall -Wextra -D__darwin__    -c -o libopenbsd/closefrom.o libopenbsd/closefrom.c
       > clang -I. -Ilibopenbsd -O2 -Wall -Wextra -D__darwin__    -c -o pam.o pam.c
       > clang -I. -Ilibopenbsd -O2 -Wall -Wextra -D__darwin__    -c -o timestamp.o timestamp.c
       > timestamp.c:65:10: fatal error: 'sys/vfs.h' file not found
       > #include <sys/vfs.h>
       >          ^~~~~~~~~~~
       > 1 error generated.
       > make: *** [<builtin>: timestamp.o] Error 1
       > rm parse.c
       For full logs, run 'nix log /nix/store/66fvlrxqaazlazxybp2cp4g1v336gac5-doas-6.8.2.drv'.
       ```

[cole-h]

doas cross compiles for me just fine:

$ nix-build -A pkgsCross.aarch64-multiplatform-musl.doas
/nix/store/lz44law50ipjjindnlasrm8b605fp8yn-doas-aarch64-unknown-linux-musl-6.8.2
$ nix-build -A pkgsCross.aarch64-multiplatform.doas
/nix/store/nizpkqa1xiijnj8fqdzv6wcz5n1j2cnf-doas-aarch64-unknown-linux-gnu-6.8.2
$ git rev-parse HEAD
74c56f2e51d08f0196ed48d32e01d5d408e64451

@dsalaza4 Can you confirm if cross-compilation is still broken for you on the latest master?

---

@jpverde I wouldn't expect nix-shell -p doas to work on a Macbook considering the package only supports Linux:

nixpkgs/pkgs/tools/security/doas/default.nix

Line 57 in 74c56f2

platforms = platforms.linux;

[dsalaza4]

@cole-h

• I was using 53dad94, which triggered the yacc error.
• I thought I was at the latest version based on the pkg source code history: https://github.com/NixOS/nixpkgs/commits/nixos-unstable/pkgs/tools/security/doas/default.nix
• When I upgraded to b01f185 it worked.

It looks like I'm missing something here 🤔

Closing this issue!

[cole-h]

I'm also missing something, since even 53dad94 builds successfully for me 😅

$ nix-build -A pkgsCross.aarch64-multiplatform.doas
/nix/store/nizpkqa1xiijnj8fqdzv6wcz5n1j2cnf-doas-aarch64-unknown-linux-gnu-6.8.2
$ nix-build -A pkgsCross.aarch64-multiplatform-musl.doas
/nix/store/lz44law50ipjjindnlasrm8b605fp8yn-doas-aarch64-unknown-linux-musl-6.8.2
$ git rev-parse HEAD
53dad94e874c9586e71decf82d972dfb640ef044

Maybe you have some overlays somewhere messing with this?

Regardless, glad it's solved for you now :)