neovim 0.5.0 fails to build

[peperunas]

Describe the bug

Neovim 0.5.0 fails to build due to incorrect permissions.

Steps To Reproduce

Steps to reproduce the behavior:

1. Install neovim from unstable

Additional context

substituteStream(): WARNING: pattern 'Name=Neovim' doesn't match anything in file '/nix/store/0a1ybbq252b46dzi5g644rfmmkbbblz8-neovim-0.5.0/share/applications/nvim.desktop'
/nix/store/7xdjqpzv0w4pkz8z2hbv8sj98zhy6g7n-hook/nix-support/setup-hook: line 40: /nix/store/s50aclcycg186nigchin5mnlsdfr3lzl-neovim-0.5.0/bin/nvim-python3: Permission denied

Notify maintainers

@Ma27 @manveru @rvolosatovs

Metadata

 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.62, NixOS, 21.05.20210906.fd6dba4 (Okapi)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.4pre20210802_47e96bb`
 - channels(root): `"nixos-21.11pre309670.253aecf69ed, home-manager"`
 - channels(giulio): `""`
 - nixpkgs: `/nix/store/gk0xwmhhxb48i2kxlyrsm0vrczjjf6ja-source`

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

[rvolosatovs]

substituteStream(): WARNING: pattern 'Name=Neovim' doesn't match anything in file '/nix/store/0a1ybbq252b46dzi5g644rfmmkbbblz8-neovim-0.5.0/share/applications/nvim.desktop'

Is very concerning, I don't see how it can fail

nixpkgs/pkgs/applications/editors/neovim/wrapper.nix

Lines 58 to 59 in c50a3bf

	substitute ${neovim}/share/applications/nvim.desktop $out/share/applications/nvim.desktop \
	--replace 'Name=Neovim' 'Name=WrappedNeovim'

I cannot reproduce this on 253aecf corresponding to your root channel:

$ git checkout 253aecf69ed && nix run -f . neovim -c nvim -u NONE -c :checkhealth

Also not on latest nixos-unstable:

$ git checkout upstream/nixpkgs-unstable && git rev-parse HEAD && nix run -f . neovim -c nvim -u NONE -c :checkhealth
HEAD is now at 071317d5432 Merge pull request #137754 from r-ryantm/auto-update/duckdb
071317d543205ee5f5611d391a37582f9b282240 

My initial feeling was to blame #136429, but it does not look like it changed anything that could cause the error and I cannot reproduce the error even with the PR in the tree

So it looks like something is wrong in your environment? Perhaps you have an overlay active?

Did it work before? Is it feasible for you to bisect and figure out which commit broke it?

[peperunas]

I am using neovim unstable from the home-manager module. Could this be the breaker?

[rvolosatovs]

I would start with trying nix run nixpkgs.neovim -c nvim -u NONE -c :checkhealth (assuming you are on "legacy" nix)

If it works - then the culprit is home-manager indeed, if it does not - then likely something is wrong in your environment

[rvolosatovs]

Could it be that you specified a custom neovim package in home-manager? If so, the package is probably invalid.

It looks like something other than unwrapped neovim is passed to the wrapper

[teto]

nix build -f channel:nixos-unstable neovim neovim-unwrapped work fine so it's probably sthg wrong in your config

[figsoda]

error message looks like it is trying to wrap a wrapped neovim, what is your config?

[peperunas]

I am using neovim from home-manager, this might be the culprit.

I am modifying the neovim package by using the following snippet, nothing more:

programs.neovim = {
  enable      = true;
  package = pkgs.unstable.neovim;
}

[figsoda]

what is pkgs.unstable?
if it is nixpkgs, it should probably be pkgs.unstable.neovim-unwrapped instead
https://github.com/nix-community/home-manager/blob/959217e51dbd07d0de6dcbddfbfcb4f2efdc0c1e/modules/programs/neovim.nix#L146
setting it to a wrapped neovim will cause double wrapping

[peperunas]

Absolutely, that was the issue!

I solved it by setting package = neovim-unwrapped.

As a side note, why does neovim need wrapping?

[figsoda]

the wrapper allows you to set your init file, adds support for python, node and other languages, and some other stuff
see https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/editors/neovim/wrapper.nix

[peperunas]

Awesome, thanks!

…

On 1 Oct 2021, 14:38 +0200, figsoda ***@***.***>, wrote: the wrapper allows you to set your init file, adds support for python, node and other languages, and some other stuff see https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/editors/neovim/wrapper.nix — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

[teto]

I would prefer if we adopted neovim / neovim-wrapped rather neovim-unwrapped / neovim to avoid that (but unlikely to happen due to backwards compatibility and all). Also the module could check whether package is wrapped or not.