Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add derivations for Amazon Corretto JDK (8, 11, 15) #114795

Closed
ldeck opened this issue Mar 2, 2021 · 4 comments
Closed

Please add derivations for Amazon Corretto JDK (8, 11, 15) #114795

ldeck opened this issue Mar 2, 2021 · 4 comments
Labels
0.kind: packaging request Request for a new package to be added

Comments

@ldeck
Copy link
Contributor

ldeck commented Mar 2, 2021

Project description
No-cost, multiplatform, production-ready distribution of OpenJDK.

Metadata

@ldeck ldeck added the 0.kind: packaging request Request for a new package to be added label Mar 2, 2021
@ghost
Copy link

ghost commented Mar 3, 2021

I'm not even sure if we would be allowed to redistribute the Corretto JDK for trademark reasons.

  1. Can I create and redistribute my own builds of Amazon Corretto? : If you build Amazon Corretto from source and redistribute the results, you may use the Corretto Trademarks only if it is clear in both the name of your distribution and the content associated with it that your distribution is your build of Amazon Corretto and not the official build, and you must identify the commit from which it is built, including the commit date.

Why would you want to use Coretto JDK instead of the normal jdk11 builds or AdoptOpenJDK binary releases?

@ldeck
Copy link
Contributor Author

ldeck commented Mar 9, 2021

I'd misread the prerequisites for AWS CDK (https://cdkworkshop.com/15-prerequisites/800-java.html), actually.

Nevertheless, other packager managers (e.g., Homebrew's correto cask) seem to provide this as a package, so I thought it would be useful for it to be available via nix.

Perhaps rather than building from source, it could be a derivation linking to the official packages?

@ghost
Copy link

ghost commented Mar 9, 2021

I'd misread the prerequisites for AWS CDK (https://cdkworkshop.com/15-prerequisites/800-java.html), actually.

Yeah, best just use the jdk8 package.

Perhaps rather than building from source, it could be a derivation linking to the official packages?

It's not trivial to run prebuilt binaries in a Nix environment. They need to be patched to reference (link to) shared libraries in the Nix store. Even then, I'm not sure if we would still be allowed to call it Amazon Coretto JDK since we would have to modify the binaries.

Nevertheless, other packager managers (e.g., Homebrew's correto cask) seem to provide this as a package, so I thought it would be useful for it to be available via nix.

Unless there's some feature missing in our own OpenJDK builds, I would strongly prefer not to package yet another binary JDK.

@ldeck
Copy link
Contributor Author

ldeck commented Mar 10, 2021

Fair enough @petabyteboy. Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: packaging request Request for a new package to be added
Projects
None yet
Development

No branches or pull requests

1 participant