Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Commit e483deb

Browse files
committed
Update ci.
1 parent ced12f9 commit e483deb

File tree

4 files changed

+48
-16
lines changed

4 files changed

+48
-16
lines changed

.github/workflows/publish-results.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ on:
1010
jobs:
1111
call-reusable-workflow:
1212
name: Call Reusable Testing Callback Workflow
13-
uses: NilFoundation/ci-cd/.github/workflows/reusable-crypto3-publish-result.yml@v1
13+
uses: NilFoundation/ci-cd/.github/workflows/reusable-crypto3-publish-result.yml@v1.2.1
+42
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
name: Reusable PR testing for mac and linux
2+
3+
on:
4+
workflow_call:
5+
inputs:
6+
targets:
7+
type: string
8+
description: "Make and CTest targets. If not specified, everything is tested"
9+
required: false
10+
11+
jobs:
12+
handle-syncwith:
13+
name: Call Reusable SyncWith Handler
14+
uses: NilFoundation/ci-cd/.github/workflows/[email protected]
15+
with:
16+
ci-cd-ref: 'v1.2.1'
17+
secrets: inherit
18+
19+
matrix-test-linux:
20+
name: Linux Reusable Crypto3 Testing
21+
needs:
22+
- handle-syncwith
23+
uses: NilFoundation/ci-cd/.github/workflows/[email protected]
24+
25+
secrets: inherit
26+
with:
27+
submodules-refs: ${{ needs.handle-syncwith.outputs.prs-refs }}
28+
29+
targets: ${{ inputs.targets }}
30+
31+
matrix-test-mac:
32+
name: Mac Reusable Crypto3 Testing
33+
needs:
34+
- handle-syncwith
35+
uses: NilFoundation/ci-cd/.github/workflows/[email protected]
36+
37+
secrets: inherit
38+
with:
39+
submodules-refs: ${{ needs.handle-syncwith.outputs.prs-refs }}
40+
41+
targets: ${{ inputs.targets }}
42+

.github/workflows/pull-request.yml

+3-13
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,8 @@ on:
77
- synchronize
88

99
jobs:
10-
handle-syncwith:
11-
name: Call Reusable SyncWith Handler
12-
uses: NilFoundation/ci-cd/.github/workflows/reusable-handle-syncwith.yml@v1
13-
with:
14-
ci-cd-ref: 'v1'
15-
secrets: inherit
10+
run-pull-request-actions:
11+
name: Reusable Crypto3 Testing
12+
uses: ./.github/workflows/pull-request-action.yml
1613

17-
matrix-test:
18-
name: Call Reusable Crypto3 Testing
19-
needs:
20-
- handle-syncwith
21-
uses: NilFoundation/ci-cd/.github/workflows/reusable-crypto3-testing.yml@v1
22-
with:
23-
submodules-refs: ${{ needs.handle-syncwith.outputs.prs-refs }}
2414
secrets: inherit

include/nil/crypto3/marshalling/algebra/processing/detail/curve_element.hpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,9 @@ namespace nil {
113113
assert(!sign);
114114
return group_affine_value_type(base_field_value_type::zero(), y);
115115
}
116-
base_field_value_type x = x2.pow((base_field_type::modulus + 3) / 8);
116+
base_field_value_type x = x2.pow((base_field_type::modulus + 3u) / 8);
117117
if (!(x * x - x2).is_zero()) {
118-
x = x * base_field_value_type(2).pow((base_field_type::modulus - 1) / 4);
118+
x = x * base_field_value_type(2u).pow((base_field_type::modulus - 1u) / 4);
119119
// TODO: throw catchable error, for example return status
120120
assert((x * x - x2).is_zero());
121121
}

0 commit comments

Comments
 (0)