Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tags for transactions #101

Closed
phil0x2e opened this issue Nov 29, 2022 · 11 comments · Fixed by #628
Closed

Implement tags for transactions #101

phil0x2e opened this issue Nov 29, 2022 · 11 comments · Fixed by #628
Labels
feature New feature or request in-beta This issue is fixed in a beta version
Milestone

Comments

@phil0x2e
Copy link

It would be nice to have the ability to add multiple groups to transactions.

For example a transaction could be in the group "recurring payments" and "donations".
This would really help to organize transactions, which fit more than one group.

@nlogozzo nlogozzo added the feature New feature or request label Nov 29, 2022
@fsobolev
Copy link
Member

I now imagine groups entry in transaction dialog similar to the labels list here on github... Colored pill buttons, with a group name and small x button inside, circular + button on the right side of the list that opens a popup with a list of all groups. Yeah, looking at my contributions, it seems like I'm thrilled by colors, haha 🤣 Gonna make a mockup later.

@RuboGubo
Copy link

Just to throw my two pence in: If we do implement this, then it would make the count up on the side more complicated, as the sum off all the groups would not equal your total money.

@nlogozzo
Copy link
Member

Just to throw my two pence in: If we do implement this, then it would make the count up on the side more complicated, as the sum off all the groups would not equal your total money.

Well the Total, income, and expensas of the account is calculated only from the transactions themselves and has nothing to do with groups, hence why they are two separate sections.

@zothma
Copy link
Contributor

zothma commented Dec 2, 2022

If we do implement this feature, this will create some other problems: the CSV will be almost impossible to do, unless each transaction is duplicated... It would look like that for a transaction that belongs to two groups Group1 and Group2:

1;2022-11-27;Test 1;1;0;30;rgb(53,132,228);-1;Group1;Description 1
1;2022-11-27;Test 1;1;0;30;rgb(53,132,228);-1;Group2;Description 2

This would ruin the ability to use the CSV in an external tool like Excel. Plus, from what I've seen in many apps, including my banking app, only one group is added to a transaction...

@fsobolev
Copy link
Member

fsobolev commented Dec 2, 2022

the CSV will be almost impossible to do, unless each transaction is duplicated...

Groups in CSV can be comma separated, so the only problem is to mask commas in groups' names and descriptions when exporting. Or it's possible to use another symbol as separator for groups in CSV (maybe |?) So your example will look like this:

1;2022-11-27;Test 1;1;0;30;rgb(53,132,228);1|2;Group1|Group 2;Description 1|Description 2

Plus, from what I've seen in many apps, including my banking app, only one group is added to a transaction...

Sounds awesome to me, implementing a feature that other apps don't have! 😄

@zothma
Copy link
Contributor

zothma commented Dec 2, 2022

Groups in CSV can be comma separated, so the only problem is to mask commas in groups' names and descriptions when exporting. Or it's possible to use another symbol as separator for groups in CSV (maybe |?)

This idea does solve my problem indeed. However, as CSV may only be used for apps like Excel and Calc, it does make it quite hard to read. It would have been relevant to do it like so if CSV were used to transfer data between accounts, but as this feature has been added now, I don't really see the interest. Finally, changing the CSV once more makes all previous CSV exports impossible to import again.

This feature would also mean to change once more the structure of the SQL file .nmoney, by adding a table for mapping transactions and groups and by removing a column from the transaction table.

As another problem I'd see, and this reflects what @RuboGubo was saying, it makes the total of all groups different from the total of all transactions, so some charts like a pie chart wouldn't be possible to do in the PDF report

@kdw2060
Copy link

kdw2060 commented Dec 30, 2022

Came here to make the same suggestion about categories/tags, so thumbs up for this idea.

I'd like to add one more suggestion: make the description an optional field. At the moment it is mandatory, but I feel like categories/tags are quite self-explanatory and most of the time don't need a description (e.g. I have categories like 'insurance', 'groceries', ...).

@fsobolev
Copy link
Member

make the description an optional field

#111

@fsobolev fsobolev changed the title Allow transactions to have multiple groups Implement tags for transactions Jan 10, 2023
@nlogozzo
Copy link
Member

nlogozzo commented Feb 6, 2023

@fsobolev So how do we feel about doing this next? Do you want to make some mockups of how a tagging system would work (in conjunction with the current grouping system)?

@fsobolev
Copy link
Member

fsobolev commented Feb 6, 2023

Tags mockup

This is my old mockup. Tbh I want to change it completely, but basically the idea and functionality can be the same: each transacion can have any number of tags, they're not in any way related or connected to groups. I don't think we have a good place in sidebar to always show tags there, but maybe we can show them somewhere when a user searches transactions, I have a few ideas, will do some mockups later and we'll see what looks best. I think we can make tags immutable, meaning once created they can't be changed, only deleted, this way we'll be able to have tags as comma separated list in Tags column in CSV, without Ids... need to save colors somehow tho.

@nlogozzo nlogozzo added this to the V2023.2.1 milestone Feb 6, 2023
@nlogozzo nlogozzo modified the milestones: V2023.2.1, V2023.3.0 Feb 17, 2023
@nlogozzo nlogozzo mentioned this issue Mar 4, 2023
@nlogozzo nlogozzo removed this from the V2023.3.0 milestone Mar 14, 2023
@nlogozzo nlogozzo added this to the V2023.4.2 milestone Apr 3, 2023
@nlogozzo nlogozzo modified the milestones: V2023.6.0, V2023.6.1 May 28, 2023
@nlogozzo nlogozzo removed this from the V2023.6.1 milestone Jun 22, 2023
@fsobolev fsobolev added this to the V2023.8.0 milestone Aug 8, 2023
@fsobolev fsobolev mentioned this issue Aug 9, 2023
5 tasks
@nlogozzo nlogozzo added the in-beta This issue is fixed in a beta version label Aug 12, 2023
@nlogozzo
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request in-beta This issue is fixed in a beta version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants