Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App may get confused between a GOG and HeroicGOG game when both are installed. #2685

Open
Sewer56 opened this issue Feb 19, 2025 · 1 comment
Labels
Bug Something isn't working priority-low A low priority task.

Comments

@Sewer56
Copy link
Member

Sewer56 commented Feb 19, 2025

Bug Report

Summary

When a GOG game is installed in Wine

Image

And same GOG game is installed via Heroic

Image

The App can get confused between installs.

Debugger Info

Path in MyGames & passed to CreateLoadout

Image

Path in Loadout view, once you manage the game

Image

(Specifically Diagnostics, I haven't identified all parts which use the incorrect path; could even be loadout creation itself)

The path for GOG was used, when HeroicGOG game was managed.

Steps to reproduce

  1. Install game in Wine
  2. Install game via Heroic
  3. Manage game
  4. Pray you reproduce it.

What is the expected behaviour?

Normally we assume that you can't have multiple installs of a game from a single store.

This is one of those cases where you can actually have that; and it seems this gets the App mixed up.
Probably because somewhere along the line we treat both as 'GOG'.

Other information

I would assume this happens with 2 proper installs.

In my case, I removed the Wine version by manually deleting the folder.
Which in turn, left registry entries behind that GameFinder is presumably picking up.

I've only learned about wine uninstaller very recently, so never uninstalled properly, I've not know about it for over a decade.
So I've had this weird case where App shows a GOG Stardew despite me not thinking I had it installed.

Maybe we could add a check to GameFinder to see if game folder exists for found games, or one in the App, will see what @erri120 thinks. (e.g. do we need issue in GameFinder repo?)

@Sewer56 Sewer56 assigned Sewer56 and unassigned Sewer56 Feb 19, 2025
@Sewer56 Sewer56 added the Bug Something isn't working label Feb 19, 2025
@Sewer56 Sewer56 added this to MVP Feb 19, 2025
@Sewer56 Sewer56 added the priority-low A low priority task. label Feb 19, 2025
@Sewer56
Copy link
Member Author

Sewer56 commented Feb 19, 2025

(This is very low priority, likelihood of a user encountering this is low; and not for initial Beta release. But the 'ghost install' part that caused this in my case may be a bit higher, as that presumably also works on Windows by deleting game folder, leaving registry entry behind.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working priority-low A low priority task.
Projects
Status: No status
Development

No branches or pull requests

1 participant