Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Run sphinx build in nitpicky mode to check internal links #1731

Closed
3 tasks done
rly opened this issue Jul 21, 2023 · 2 comments · Fixed by #1827
Closed
3 tasks done

[Feature]: Run sphinx build in nitpicky mode to check internal links #1731

rly opened this issue Jul 21, 2023 · 2 comments · Fixed by #1827
Assignees
Labels
category: enhancement improvements of code or code behavior help wanted: good first issue request for community contributions that are good for new contributors priority: low alternative solution already working and/or relevant to only specific user(s) topic: docs issues related to documentation

Comments

@rly
Copy link
Contributor

rly commented Jul 21, 2023

What would you like to see added to PyNWB?

We can run sphinx-build -n ... to have sphinx check internal links. We currently check external links through the sphinx --linkcheck option but this does not check whether references like pynwb.base.ProcessingModules exists. When running this locally, I get over 100 broken internal links in docstrings, and about 30 broken internal links in tutorials.

Is your feature request related to a problem?

No response

What solution would you like?

Update Makefile and make.bat in docs to use the sphinx option -n. Run make html. Fix all the warnings about broken links.

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

@rly rly added category: enhancement improvements of code or code behavior topic: docs issues related to documentation help wanted: good first issue request for community contributions that are good for new contributors priority: low alternative solution already working and/or relevant to only specific user(s) labels Jul 21, 2023
@rly
Copy link
Contributor Author

rly commented Jul 21, 2023

We can also set this option and configure ignores in conf.py : https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-nitpicky

@bendichter
Copy link
Contributor

Would you clarify this? If I run

sphinx-build -n source build html

I don't see any errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior help wanted: good first issue request for community contributions that are good for new contributors priority: low alternative solution already working and/or relevant to only specific user(s) topic: docs issues related to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants