Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Hiding form hints until Submit #636

Closed
bendichter opened this issue Mar 8, 2024 · 4 comments
Closed

[Feature]: Hiding form hints until Submit #636

bendichter opened this issue Mar 8, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@bendichter
Copy link
Collaborator

What would you like to see added to the NWB GUIDE?

For example, I find this amount of red in a form to be unsettling:

image

Can we please alter this so that the "hints" that appear below each text field only pop up after you hit "Create" with invalid inputs?

Do you have any interest in helping implement the feature?

Yes.

Code of Conduct

Yes

Did you confirm this feature was not already reported?

Yes

@bendichter bendichter added the enhancement New feature or request label Mar 8, 2024
@CodyCBakerPhD
Copy link
Collaborator

Specifically, the request seems to be to not display error flags for fields that are, in some cases, default in an error state (usually because missing when required)

I believe this results because it is the common mechanism of any error to display the flag explaining that error

@garrettmflynn Question is, how hard would this be to separate from the normal behavior of user typing in an input and the flag only being displayed on invalidation of that input?

@bendichter
Copy link
Collaborator Author

Yeah, I think technically speaking what I want is to skip validation a first and then apply validation either when a user deselects a field or when a user its submit (or similar).

@garrettmflynn
Copy link
Member

This was already implemented in #632, we just haven't merged it in yet 😅

@CodyCBakerPhD
Copy link
Collaborator

Looks like @bendichter approved it but then someone forgot to hit the merge button

closed with #632, reopen otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants