Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdp): avoid throwing errors for unknown session IDs #241

Merged

Conversation

derevnjuk
Copy link
Member

closes #173

@derevnjuk derevnjuk added the Type: bug Something isn't working label Mar 14, 2023
@derevnjuk derevnjuk self-assigned this Mar 14, 2023
@codeclimate
Copy link

codeclimate bot commented Mar 14, 2023

Code Climate has analyzed commit 432435d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.3% (0.0% change).

View more on Code Climate.

@cypress
Copy link

cypress bot commented Mar 14, 2023

Passing run #7 ↗︎

0 32 5 0 Flakiness 0

Details:

Merge 432435d into a3e474c...
Project: cypress-har-generator Commit: 016f5f54e1 ℹ️
Status: Passed Duration: 01:53 💡
Started: Mar 14, 2023 2:37 PM Ended: Mar 14, 2023 2:39 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@derevnjuk derevnjuk force-pushed the fix_#173/avoid_throwing_errors_for_unknown_session_IDs branch from f886830 to 0a6b6c4 Compare March 14, 2023 14:23
@derevnjuk derevnjuk force-pushed the fix_#173/avoid_throwing_errors_for_unknown_session_IDs branch from 0a6b6c4 to 432435d Compare March 14, 2023 14:34
@derevnjuk derevnjuk merged commit 111981b into master Mar 14, 2023
@derevnjuk derevnjuk deleted the fix_#173/avoid_throwing_errors_for_unknown_session_IDs branch March 14, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin crashes on test run
1 participant