From 808cac01b6c80e01e023e42ae90cbec1a7bd473b Mon Sep 17 00:00:00 2001 From: hardikl Date: Fri, 29 Sep 2023 17:34:31 +0530 Subject: [PATCH 1/4] feat: Adding new panels in Disk dashboard --- conf/restperf/9.12.0/disk.yaml | 2 +- conf/zapiperf/cdot/9.8.0/disk.yaml | 1 + grafana/dashboards/cmode/disk.json | 532 ++++++++++++++++++++++++++++- 3 files changed, 525 insertions(+), 10 deletions(-) diff --git a/conf/restperf/9.12.0/disk.yaml b/conf/restperf/9.12.0/disk.yaml index 97a97bf67..8e7493598 100644 --- a/conf/restperf/9.12.0/disk.yaml +++ b/conf/restperf/9.12.0/disk.yaml @@ -41,7 +41,7 @@ plugins: - aggr ... - plex node,aggr,plex # - plex node aggr - # - raid node aggr plex + - raid node,aggr,disk,plex,raid - Max: - node<>node_disk_max - aggr<>aggr_disk_max ... diff --git a/conf/zapiperf/cdot/9.8.0/disk.yaml b/conf/zapiperf/cdot/9.8.0/disk.yaml index 9ee714412..7769e2d3c 100644 --- a/conf/zapiperf/cdot/9.8.0/disk.yaml +++ b/conf/zapiperf/cdot/9.8.0/disk.yaml @@ -41,6 +41,7 @@ plugins: - node - aggr ... - plex node,aggr,plex + - raid node,aggr,disk,plex,raid Max: # plugin will create max for each object diff --git a/grafana/dashboards/cmode/disk.json b/grafana/dashboards/cmode/disk.json index 8cf4541fd..606915f28 100644 --- a/grafana/dashboards/cmode/disk.json +++ b/grafana/dashboards/cmode/disk.json @@ -937,7 +937,7 @@ "pluginVersion": "8.1.8", "targets": [ { - "expr": "topk($TopResources, aggr_disk_max_total_transfers{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$TopDiskTotalTransfers\"})", + "expr": "topk($TopResources, aggr_disk_max_total_transfers{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$TopMaxDiskTotalTransfers\"})", "format": "table", "hide": false, "instant": true, @@ -946,7 +946,7 @@ "refId": "C" }, { - "expr": "topk($TopResources, aggr_disk_max_busy{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$TopDiskBusy\"})", + "expr": "topk($TopResources, aggr_disk_max_busy{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$TopMaxDiskBusy\"})", "format": "table", "hide": false, "instant": true, @@ -1059,7 +1059,7 @@ "pluginVersion": "8.1.8", "targets": [ { - "expr": "topk($TopResources, max by (node, aggr) (aggr_disk_max_busy{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$TopDiskBusy\"}))", + "expr": "topk($TopResources, max by (node, aggr) (aggr_disk_max_busy{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$TopMaxDiskBusy\"}))", "interval": "", "legendFormat": "{{node}} - {{aggr}}", "refId": "A" @@ -1148,7 +1148,7 @@ "pluginVersion": "8.1.8", "targets": [ { - "expr": "topk($TopResources, max by (node, aggr) (aggr_disk_max_total_transfers{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$TopDiskTotalTransfers\"}))", + "expr": "topk($TopResources, max by (node, aggr) (aggr_disk_max_total_transfers{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$TopMaxDiskTotalTransfers\"}))", "interval": "", "legendFormat": "{{node}} - {{aggr}}", "refId": "A" @@ -1347,6 +1347,376 @@ "title": "Top $TopResources Aggregates by User Write IOP Size", "type": "timeseries" }, + { + "datasource": "${DS_PROMETHEUS}", + "description": "Average latency per block in microseconds for user read operations", + "fieldConfig": { + "defaults": { + "color": { + "mode": "palette-classic" + }, + "custom": { + "axisLabel": "", + "axisPlacement": "auto", + "barAlignment": 0, + "drawStyle": "line", + "fillOpacity": 10, + "gradientMode": "none", + "hideFrom": { + "legend": false, + "tooltip": false, + "viz": false + }, + "lineInterpolation": "linear", + "lineWidth": 1, + "pointSize": 5, + "scaleDistribution": { + "type": "linear" + }, + "showPoints": "never", + "spanNulls": true, + "stacking": { + "group": "A", + "mode": "none" + }, + "thresholdsStyle": { + "mode": "off" + } + }, + "decimals": 2, + "mappings": [], + "thresholds": { + "mode": "absolute", + "steps": [ + { + "color": "green", + "value": null + }, + { + "color": "red", + "value": 80 + } + ] + }, + "unit": "µs" + }, + "overrides": [] + }, + "gridPos": { + "h": 8, + "w": 12, + "x": 0, + "y": 29 + }, + "id": 58, + "options": { + "legend": { + "calcs": [ + "mean", + "lastNotNull", + "max" + ], + "displayMode": "table", + "placement": "bottom" + }, + "tooltip": { + "mode": "single", + "sort": "none" + } + }, + "pluginVersion": "8.1.8", + "targets": [ + { + "exemplar": false, + "expr": "topk($TopResources, (raid_disk_user_read_latency{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\",disk=~\"$TopDiskUserReadLatency\"}))", + "format": "time_series", + "instant": false, + "interval": "", + "legendFormat": "{{disk}}", + "refId": "A" + } + ], + "title": "Top $TopResources Disks by User Read Latency", + "type": "timeseries" + }, + { + "datasource": "${DS_PROMETHEUS}", + "description": "Average latency per block in microseconds for user write operations", + "fieldConfig": { + "defaults": { + "color": { + "mode": "palette-classic" + }, + "custom": { + "axisLabel": "", + "axisPlacement": "auto", + "barAlignment": 0, + "drawStyle": "line", + "fillOpacity": 10, + "gradientMode": "none", + "hideFrom": { + "legend": false, + "tooltip": false, + "viz": false + }, + "lineInterpolation": "linear", + "lineWidth": 1, + "pointSize": 5, + "scaleDistribution": { + "type": "linear" + }, + "showPoints": "never", + "spanNulls": true, + "stacking": { + "group": "A", + "mode": "none" + }, + "thresholdsStyle": { + "mode": "off" + } + }, + "decimals": 2, + "mappings": [], + "thresholds": { + "mode": "absolute", + "steps": [ + { + "color": "green", + "value": null + }, + { + "color": "red", + "value": 80 + } + ] + }, + "unit": "µs" + }, + "overrides": [] + }, + "gridPos": { + "h": 8, + "w": 12, + "x": 12, + "y": 29 + }, + "id": 61, + "options": { + "legend": { + "calcs": [ + "mean", + "lastNotNull", + "max" + ], + "displayMode": "table", + "placement": "bottom" + }, + "tooltip": { + "mode": "single", + "sort": "none" + } + }, + "pluginVersion": "8.1.8", + "targets": [ + { + "exemplar": false, + "expr": "topk($TopResources, (raid_disk_user_write_latency{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\",disk=~\"$TopDiskUserWriteLatency\"}))", + "format": "time_series", + "instant": false, + "interval": "", + "legendFormat": "{{disk}}", + "refId": "A" + } + ], + "title": "Top $TopResources Disks by User Write Latency", + "type": "timeseries" + }, + { + "datasource": "${DS_PROMETHEUS}", + "description": "Total number of disk operations involving data transfer initiated per second", + "fieldConfig": { + "defaults": { + "color": { + "mode": "palette-classic" + }, + "custom": { + "axisLabel": "", + "axisPlacement": "auto", + "barAlignment": 0, + "drawStyle": "line", + "fillOpacity": 10, + "gradientMode": "none", + "hideFrom": { + "legend": false, + "tooltip": false, + "viz": false + }, + "lineInterpolation": "linear", + "lineWidth": 1, + "pointSize": 5, + "scaleDistribution": { + "type": "linear" + }, + "showPoints": "never", + "spanNulls": true, + "stacking": { + "group": "A", + "mode": "none" + }, + "thresholdsStyle": { + "mode": "off" + } + }, + "decimals": 0, + "mappings": [], + "thresholds": { + "mode": "absolute", + "steps": [ + { + "color": "green", + "value": null + }, + { + "color": "red", + "value": 80 + } + ] + }, + "unit": "short" + }, + "overrides": [] + }, + "gridPos": { + "h": 8, + "w": 12, + "x": 0, + "y": 37 + }, + "id": 60, + "options": { + "legend": { + "calcs": [ + "mean", + "lastNotNull", + "max" + ], + "displayMode": "table", + "placement": "bottom" + }, + "tooltip": { + "mode": "single", + "sort": "none" + } + }, + "pluginVersion": "8.1.8", + "targets": [ + { + "exemplar": false, + "expr": "topk($TopResources, (raid_disk_total_transfers{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\",disk=~\"$TopDiskTotalTransfers\"}))", + "format": "time_series", + "instant": false, + "interval": "", + "legendFormat": "{{disk}}", + "refId": "A" + } + ], + "title": "Top $TopResources Disks by Total Transfers", + "type": "timeseries" + }, + { + "datasource": "${DS_PROMETHEUS}", + "description": "The utilization percent of the disk in the selected time range", + "fieldConfig": { + "defaults": { + "color": { + "mode": "palette-classic" + }, + "custom": { + "axisLabel": "", + "axisPlacement": "auto", + "barAlignment": 0, + "drawStyle": "line", + "fillOpacity": 10, + "gradientMode": "none", + "hideFrom": { + "legend": false, + "tooltip": false, + "viz": false + }, + "lineInterpolation": "linear", + "lineWidth": 1, + "pointSize": 5, + "scaleDistribution": { + "type": "linear" + }, + "showPoints": "never", + "spanNulls": true, + "stacking": { + "group": "A", + "mode": "none" + }, + "thresholdsStyle": { + "mode": "off" + } + }, + "decimals": 0, + "mappings": [], + "max": 100, + "min": 0, + "thresholds": { + "mode": "absolute", + "steps": [ + { + "color": "green", + "value": null + }, + { + "color": "red", + "value": 80 + } + ] + }, + "unit": "percent" + }, + "overrides": [] + }, + "gridPos": { + "h": 8, + "w": 12, + "x": 12, + "y": 37 + }, + "id": 59, + "options": { + "legend": { + "calcs": [ + "mean", + "lastNotNull", + "max" + ], + "displayMode": "table", + "placement": "bottom" + }, + "tooltip": { + "mode": "single", + "sort": "none" + } + }, + "pluginVersion": "8.1.8", + "targets": [ + { + "exemplar": false, + "expr": "topk($TopResources, (raid_disk_busy{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\",disk=~\"$TopDiskBusy\"}))", + "format": "time_series", + "instant": false, + "interval": "", + "legendFormat": "{{disk}}", + "refId": "A" + } + ], + "title": "Top $TopResources Disks by Disk Busy", + "type": "timeseries" + }, { "collapsed": true, "datasource": "${DS_PROMETHEUS}", @@ -1354,7 +1724,7 @@ "h": 1, "w": 24, "x": 0, - "y": 29 + "y": 45 }, "id": 22, "panels": [ @@ -1608,7 +1978,7 @@ "h": 10, "w": 24, "x": 0, - "y": 30 + "y": 46 }, "id": 18, "interval": "1m", @@ -1834,7 +2204,7 @@ "h": 1, "w": 24, "x": 0, - "y": 30 + "y": 56 }, "id": 28, "panels": [ @@ -2570,6 +2940,58 @@ "type": "query", "useTags": false }, + { + "allValue": null, + "current": {}, + "datasource": "Prometheus", + "definition": "label_values(aggr_disk_busy{cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\"}, plex)", + "description": null, + "error": null, + "hide": 0, + "includeAll": true, + "label": null, + "multi": true, + "name": "Plex", + "options": [], + "query": { + "query": "label_values(aggr_disk_busy{cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\"}, plex)", + "refId": "StandardVariableQuery" + }, + "refresh": 2, + "regex": "", + "skipUrlSync": false, + "sort": 1, + "tagValuesQuery": "", + "tagsQuery": "", + "type": "query", + "useTags": false + }, + { + "allValue": null, + "current": {}, + "datasource": "Prometheus", + "definition": "label_values(aggr_disk_busy{cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\"}, raid)", + "description": null, + "error": null, + "hide": 0, + "includeAll": true, + "label": null, + "multi": true, + "name": "Raid", + "options": [], + "query": { + "query": "label_values(aggr_disk_busy{cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\"}, raid)", + "refId": "StandardVariableQuery" + }, + "refresh": 2, + "regex": "", + "skipUrlSync": false, + "sort": 1, + "tagValuesQuery": "", + "tagsQuery": "", + "type": "query", + "useTags": false + }, { "allValue": null, "current": { @@ -2718,7 +3140,7 @@ "includeAll": true, "label": null, "multi": true, - "name": "TopDiskBusy", + "name": "TopMaxDiskBusy", "options": [], "query": { "query": "query_result(topk($TopResources, max by (aggr) (avg_over_time(aggr_disk_max_busy{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\"}[${__range}]))))", @@ -2741,7 +3163,7 @@ "includeAll": true, "label": null, "multi": true, - "name": "TopDiskTotalTransfers", + "name": "TopMaxDiskTotalTransfers", "options": [], "query": { "query": "query_result(topk($TopResources, max by (aggr) (avg_over_time(aggr_disk_max_total_transfers{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\"}[${__range}]))))", @@ -2752,6 +3174,98 @@ "skipUrlSync": false, "sort": 0, "type": "query" + }, + { + "allValue": null, + "current": {}, + "datasource": "Prometheus", + "definition": "query_result(topk($TopResources, (avg_over_time(raid_disk_user_read_latency{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\"}[${__range}]))))", + "description": null, + "error": null, + "hide": 2, + "includeAll": true, + "label": null, + "multi": true, + "name": "TopDiskUserReadLatency", + "options": [], + "query": { + "query": "query_result(topk($TopResources, (avg_over_time(raid_disk_user_read_latency{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\"}[${__range}]))))", + "refId": "StandardVariableQuery" + }, + "refresh": 2, + "regex": ".*disk=\\\"(.*?)\\\".*", + "skipUrlSync": false, + "sort": 0, + "type": "query" + }, + { + "allValue": null, + "current": {}, + "datasource": "Prometheus", + "definition": "query_result(topk($TopResources, (avg_over_time(raid_disk_user_write_latency{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\"}[${__range}]))))", + "description": null, + "error": null, + "hide": 2, + "includeAll": true, + "label": null, + "multi": true, + "name": "TopDiskUserWriteLatency", + "options": [], + "query": { + "query": "query_result(topk($TopResources, (avg_over_time(raid_disk_user_write_latency{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\"}[${__range}]))))", + "refId": "StandardVariableQuery" + }, + "refresh": 2, + "regex": ".*disk=\\\"(.*?)\\\".*", + "skipUrlSync": false, + "sort": 0, + "type": "query" + }, + { + "allValue": null, + "current": {}, + "datasource": "Prometheus", + "definition": "query_result(topk($TopResources, (avg_over_time(raid_disk_total_transfers{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\"}[${__range}]))))", + "description": null, + "error": null, + "hide": 2, + "includeAll": true, + "label": null, + "multi": true, + "name": "TopDiskTotalTransfers", + "options": [], + "query": { + "query": "query_result(topk($TopResources, (avg_over_time(raid_disk_total_transfers{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\"}[${__range}]))))", + "refId": "StandardVariableQuery" + }, + "refresh": 2, + "regex": ".*disk=\\\"(.*?)\\\".*", + "skipUrlSync": false, + "sort": 0, + "type": "query" + }, + { + "allValue": null, + "current": {}, + "datasource": "Prometheus", + "definition": "query_result(topk($TopResources, (avg_over_time(raid_disk_busy{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\"}[${__range}]))))", + "description": null, + "error": null, + "hide": 2, + "includeAll": true, + "label": null, + "multi": true, + "name": "TopDiskBusy", + "options": [], + "query": { + "query": "query_result(topk($TopResources, (avg_over_time(raid_disk_busy{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\"}[${__range}]))))", + "refId": "StandardVariableQuery" + }, + "refresh": 2, + "regex": ".*disk=\\\"(.*?)\\\".*", + "skipUrlSync": false, + "sort": 0, + "type": "query" } ] }, From 425c68f99461fb4d14485a7a7e11da83ce9e1fde Mon Sep 17 00:00:00 2001 From: hardikl Date: Tue, 3 Oct 2023 19:40:01 +0530 Subject: [PATCH 2/4] feat: separate Raid-level overview panels --- grafana/dashboards/cmode/disk.json | 699 +++++++++++++++-------------- 1 file changed, 357 insertions(+), 342 deletions(-) diff --git a/grafana/dashboards/cmode/disk.json b/grafana/dashboards/cmode/disk.json index 606915f28..54c7b7f52 100644 --- a/grafana/dashboards/cmode/disk.json +++ b/grafana/dashboards/cmode/disk.json @@ -1348,374 +1348,389 @@ "type": "timeseries" }, { + "collapsed": true, "datasource": "${DS_PROMETHEUS}", - "description": "Average latency per block in microseconds for user read operations", - "fieldConfig": { - "defaults": { - "color": { - "mode": "palette-classic" - }, - "custom": { - "axisLabel": "", - "axisPlacement": "auto", - "barAlignment": 0, - "drawStyle": "line", - "fillOpacity": 10, - "gradientMode": "none", - "hideFrom": { - "legend": false, - "tooltip": false, - "viz": false - }, - "lineInterpolation": "linear", - "lineWidth": 1, - "pointSize": 5, - "scaleDistribution": { - "type": "linear" - }, - "showPoints": "never", - "spanNulls": true, - "stacking": { - "group": "A", - "mode": "none" - }, - "thresholdsStyle": { - "mode": "off" - } - }, - "decimals": 2, - "mappings": [], - "thresholds": { - "mode": "absolute", - "steps": [ - { - "color": "green", - "value": null - }, - { - "color": "red", - "value": 80 - } - ] - }, - "unit": "µs" - }, - "overrides": [] - }, "gridPos": { - "h": 8, - "w": 12, + "h": 1, + "w": 24, "x": 0, "y": 29 }, - "id": 58, - "options": { - "legend": { - "calcs": [ - "mean", - "lastNotNull", - "max" - ], - "displayMode": "table", - "placement": "bottom" - }, - "tooltip": { - "mode": "single", - "sort": "none" - } - }, - "pluginVersion": "8.1.8", - "targets": [ + "id": 21, + "panels": [ { - "exemplar": false, - "expr": "topk($TopResources, (raid_disk_user_read_latency{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\",disk=~\"$TopDiskUserReadLatency\"}))", - "format": "time_series", - "instant": false, - "interval": "", - "legendFormat": "{{disk}}", - "refId": "A" - } - ], - "title": "Top $TopResources Disks by User Read Latency", - "type": "timeseries" - }, - { - "datasource": "${DS_PROMETHEUS}", - "description": "Average latency per block in microseconds for user write operations", - "fieldConfig": { - "defaults": { - "color": { - "mode": "palette-classic" - }, - "custom": { - "axisLabel": "", - "axisPlacement": "auto", - "barAlignment": 0, - "drawStyle": "line", - "fillOpacity": 10, - "gradientMode": "none", - "hideFrom": { - "legend": false, - "tooltip": false, - "viz": false - }, - "lineInterpolation": "linear", - "lineWidth": 1, - "pointSize": 5, - "scaleDistribution": { - "type": "linear" + "datasource": "${DS_PROMETHEUS}", + "description": "Average latency per block in microseconds for user read operations", + "fieldConfig": { + "defaults": { + "color": { + "mode": "palette-classic" + }, + "custom": { + "axisLabel": "", + "axisPlacement": "auto", + "barAlignment": 0, + "drawStyle": "line", + "fillOpacity": 10, + "gradientMode": "none", + "hideFrom": { + "legend": false, + "tooltip": false, + "viz": false + }, + "lineInterpolation": "linear", + "lineWidth": 1, + "pointSize": 5, + "scaleDistribution": { + "type": "linear" + }, + "showPoints": "never", + "spanNulls": true, + "stacking": { + "group": "A", + "mode": "none" + }, + "thresholdsStyle": { + "mode": "off" + } + }, + "decimals": 2, + "mappings": [], + "thresholds": { + "mode": "absolute", + "steps": [ + { + "color": "green", + "value": null + }, + { + "color": "red", + "value": 80 + } + ] + }, + "unit": "µs" }, - "showPoints": "never", - "spanNulls": true, - "stacking": { - "group": "A", - "mode": "none" + "overrides": [] + }, + "gridPos": { + "h": 8, + "w": 12, + "x": 0, + "y": 30 + }, + "id": 58, + "options": { + "legend": { + "calcs": [ + "mean", + "lastNotNull", + "max" + ], + "displayMode": "table", + "placement": "bottom" }, - "thresholdsStyle": { - "mode": "off" + "tooltip": { + "mode": "single", + "sort": "none" } }, - "decimals": 2, - "mappings": [], - "thresholds": { - "mode": "absolute", - "steps": [ - { - "color": "green", - "value": null - }, - { - "color": "red", - "value": 80 - } - ] - }, - "unit": "µs" - }, - "overrides": [] - }, - "gridPos": { - "h": 8, - "w": 12, - "x": 12, - "y": 29 - }, - "id": 61, - "options": { - "legend": { - "calcs": [ - "mean", - "lastNotNull", - "max" + "pluginVersion": "8.1.8", + "targets": [ + { + "exemplar": false, + "expr": "topk($TopResources, (raid_disk_user_read_latency{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\",disk=~\"$TopDiskUserReadLatency\"}))", + "format": "time_series", + "instant": false, + "interval": "", + "legendFormat": "{{cluster}} - {{disk}}", + "refId": "A" + } ], - "displayMode": "table", - "placement": "bottom" + "title": "Top $TopResources Disks by User Read Latency", + "type": "timeseries" }, - "tooltip": { - "mode": "single", - "sort": "none" - } - }, - "pluginVersion": "8.1.8", - "targets": [ { - "exemplar": false, - "expr": "topk($TopResources, (raid_disk_user_write_latency{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\",disk=~\"$TopDiskUserWriteLatency\"}))", - "format": "time_series", - "instant": false, - "interval": "", - "legendFormat": "{{disk}}", - "refId": "A" - } - ], - "title": "Top $TopResources Disks by User Write Latency", - "type": "timeseries" - }, - { - "datasource": "${DS_PROMETHEUS}", - "description": "Total number of disk operations involving data transfer initiated per second", - "fieldConfig": { - "defaults": { - "color": { - "mode": "palette-classic" + "datasource": "${DS_PROMETHEUS}", + "description": "Average latency per block in microseconds for user write operations", + "fieldConfig": { + "defaults": { + "color": { + "mode": "palette-classic" + }, + "custom": { + "axisLabel": "", + "axisPlacement": "auto", + "barAlignment": 0, + "drawStyle": "line", + "fillOpacity": 10, + "gradientMode": "none", + "hideFrom": { + "legend": false, + "tooltip": false, + "viz": false + }, + "lineInterpolation": "linear", + "lineWidth": 1, + "pointSize": 5, + "scaleDistribution": { + "type": "linear" + }, + "showPoints": "never", + "spanNulls": true, + "stacking": { + "group": "A", + "mode": "none" + }, + "thresholdsStyle": { + "mode": "off" + } + }, + "decimals": 2, + "mappings": [], + "thresholds": { + "mode": "absolute", + "steps": [ + { + "color": "green", + "value": null + }, + { + "color": "red", + "value": 80 + } + ] + }, + "unit": "µs" + }, + "overrides": [] }, - "custom": { - "axisLabel": "", - "axisPlacement": "auto", - "barAlignment": 0, - "drawStyle": "line", - "fillOpacity": 10, - "gradientMode": "none", - "hideFrom": { - "legend": false, - "tooltip": false, - "viz": false + "gridPos": { + "h": 8, + "w": 12, + "x": 12, + "y": 30 + }, + "id": 61, + "options": { + "legend": { + "calcs": [ + "mean", + "lastNotNull", + "max" + ], + "displayMode": "table", + "placement": "bottom" }, - "lineInterpolation": "linear", - "lineWidth": 1, - "pointSize": 5, - "scaleDistribution": { - "type": "linear" + "tooltip": { + "mode": "single", + "sort": "none" + } + }, + "pluginVersion": "8.1.8", + "targets": [ + { + "exemplar": false, + "expr": "topk($TopResources, (raid_disk_user_write_latency{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\",disk=~\"$TopDiskUserWriteLatency\"}))", + "format": "time_series", + "instant": false, + "interval": "", + "legendFormat": "{{cluster}} - {{disk}}", + "refId": "A" + } + ], + "title": "Top $TopResources Disks by User Write Latency", + "type": "timeseries" + }, + { + "datasource": "${DS_PROMETHEUS}", + "description": "Total number of disk operations involving data transfer initiated per second", + "fieldConfig": { + "defaults": { + "color": { + "mode": "palette-classic" + }, + "custom": { + "axisLabel": "", + "axisPlacement": "auto", + "barAlignment": 0, + "drawStyle": "line", + "fillOpacity": 10, + "gradientMode": "none", + "hideFrom": { + "legend": false, + "tooltip": false, + "viz": false + }, + "lineInterpolation": "linear", + "lineWidth": 1, + "pointSize": 5, + "scaleDistribution": { + "type": "linear" + }, + "showPoints": "never", + "spanNulls": true, + "stacking": { + "group": "A", + "mode": "none" + }, + "thresholdsStyle": { + "mode": "off" + } + }, + "decimals": 0, + "mappings": [], + "thresholds": { + "mode": "absolute", + "steps": [ + { + "color": "green", + "value": null + }, + { + "color": "red", + "value": 80 + } + ] + }, + "unit": "short" }, - "showPoints": "never", - "spanNulls": true, - "stacking": { - "group": "A", - "mode": "none" + "overrides": [] + }, + "gridPos": { + "h": 8, + "w": 12, + "x": 0, + "y": 38 + }, + "id": 60, + "options": { + "legend": { + "calcs": [ + "mean", + "lastNotNull", + "max" + ], + "displayMode": "table", + "placement": "bottom" }, - "thresholdsStyle": { - "mode": "off" + "tooltip": { + "mode": "single", + "sort": "none" } }, - "decimals": 0, - "mappings": [], - "thresholds": { - "mode": "absolute", - "steps": [ - { - "color": "green", - "value": null - }, - { - "color": "red", - "value": 80 - } - ] - }, - "unit": "short" - }, - "overrides": [] - }, - "gridPos": { - "h": 8, - "w": 12, - "x": 0, - "y": 37 - }, - "id": 60, - "options": { - "legend": { - "calcs": [ - "mean", - "lastNotNull", - "max" + "pluginVersion": "8.1.8", + "targets": [ + { + "exemplar": false, + "expr": "topk($TopResources, (raid_disk_total_transfers{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\",disk=~\"$TopDiskTotalTransfers\"}))", + "format": "time_series", + "instant": false, + "interval": "", + "legendFormat": "{{cluster}} - {{disk}}", + "refId": "A" + } ], - "displayMode": "table", - "placement": "bottom" + "title": "Top $TopResources Disks by Total Transfers", + "type": "timeseries" }, - "tooltip": { - "mode": "single", - "sort": "none" - } - }, - "pluginVersion": "8.1.8", - "targets": [ { - "exemplar": false, - "expr": "topk($TopResources, (raid_disk_total_transfers{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\",disk=~\"$TopDiskTotalTransfers\"}))", - "format": "time_series", - "instant": false, - "interval": "", - "legendFormat": "{{disk}}", - "refId": "A" - } - ], - "title": "Top $TopResources Disks by Total Transfers", - "type": "timeseries" - }, - { - "datasource": "${DS_PROMETHEUS}", - "description": "The utilization percent of the disk in the selected time range", - "fieldConfig": { - "defaults": { - "color": { - "mode": "palette-classic" - }, - "custom": { - "axisLabel": "", - "axisPlacement": "auto", - "barAlignment": 0, - "drawStyle": "line", - "fillOpacity": 10, - "gradientMode": "none", - "hideFrom": { - "legend": false, - "tooltip": false, - "viz": false - }, - "lineInterpolation": "linear", - "lineWidth": 1, - "pointSize": 5, - "scaleDistribution": { - "type": "linear" + "datasource": "${DS_PROMETHEUS}", + "description": "The utilization percent of the disk in the selected time range", + "fieldConfig": { + "defaults": { + "color": { + "mode": "palette-classic" + }, + "custom": { + "axisLabel": "", + "axisPlacement": "auto", + "barAlignment": 0, + "drawStyle": "line", + "fillOpacity": 10, + "gradientMode": "none", + "hideFrom": { + "legend": false, + "tooltip": false, + "viz": false + }, + "lineInterpolation": "linear", + "lineWidth": 1, + "pointSize": 5, + "scaleDistribution": { + "type": "linear" + }, + "showPoints": "never", + "spanNulls": true, + "stacking": { + "group": "A", + "mode": "none" + }, + "thresholdsStyle": { + "mode": "off" + } + }, + "decimals": 0, + "mappings": [], + "max": 100, + "min": 0, + "thresholds": { + "mode": "absolute", + "steps": [ + { + "color": "green", + "value": null + }, + { + "color": "red", + "value": 80 + } + ] + }, + "unit": "percent" }, - "showPoints": "never", - "spanNulls": true, - "stacking": { - "group": "A", - "mode": "none" + "overrides": [] + }, + "gridPos": { + "h": 8, + "w": 12, + "x": 12, + "y": 38 + }, + "id": 59, + "options": { + "legend": { + "calcs": [ + "mean", + "lastNotNull", + "max" + ], + "displayMode": "table", + "placement": "bottom" }, - "thresholdsStyle": { - "mode": "off" + "tooltip": { + "mode": "single", + "sort": "none" } }, - "decimals": 0, - "mappings": [], - "max": 100, - "min": 0, - "thresholds": { - "mode": "absolute", - "steps": [ - { - "color": "green", - "value": null - }, - { - "color": "red", - "value": 80 - } - ] - }, - "unit": "percent" - }, - "overrides": [] - }, - "gridPos": { - "h": 8, - "w": 12, - "x": 12, - "y": 37 - }, - "id": 59, - "options": { - "legend": { - "calcs": [ - "mean", - "lastNotNull", - "max" + "pluginVersion": "8.1.8", + "targets": [ + { + "exemplar": false, + "expr": "topk($TopResources, (raid_disk_busy{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\",disk=~\"$TopDiskBusy\"}))", + "format": "time_series", + "instant": false, + "interval": "", + "legendFormat": "{{cluster}} - {{disk}}", + "refId": "A" + } ], - "displayMode": "table", - "placement": "bottom" - }, - "tooltip": { - "mode": "single", - "sort": "none" - } - }, - "pluginVersion": "8.1.8", - "targets": [ - { - "exemplar": false, - "expr": "topk($TopResources, (raid_disk_busy{datacenter=~\"$Datacenter\",cluster=~\"$Cluster\",node=~\"$Node\",aggr=~\"$Aggregate\",plex=~\"$Plex\",raid=~\"$Raid\",disk=~\"$TopDiskBusy\"}))", - "format": "time_series", - "instant": false, - "interval": "", - "legendFormat": "{{disk}}", - "refId": "A" + "title": "Top $TopResources Disks by Disk Busy", + "type": "timeseries" } ], - "title": "Top $TopResources Disks by Disk Busy", - "type": "timeseries" + "title": "Top Disks: Raid-level Overview", + "type": "row" }, { "collapsed": true, @@ -1724,7 +1739,7 @@ "h": 1, "w": 24, "x": 0, - "y": 45 + "y": 46 }, "id": 22, "panels": [ @@ -1978,7 +1993,7 @@ "h": 10, "w": 24, "x": 0, - "y": 46 + "y": 47 }, "id": 18, "interval": "1m", @@ -2204,7 +2219,7 @@ "h": 1, "w": 24, "x": 0, - "y": 56 + "y": 57 }, "id": 28, "panels": [ From 6b9cfb32d226a673cd1a467112f52bdaf011fe0f Mon Sep 17 00:00:00 2001 From: hardikl Date: Tue, 3 Oct 2023 19:53:20 +0530 Subject: [PATCH 3/4] feat: handle review comment --- grafana/dashboards/cmode/disk.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grafana/dashboards/cmode/disk.json b/grafana/dashboards/cmode/disk.json index 54c7b7f52..b368c2827 100644 --- a/grafana/dashboards/cmode/disk.json +++ b/grafana/dashboards/cmode/disk.json @@ -2817,7 +2817,7 @@ "type": "timeseries" } ], - "title": "Disk Utilization: Node-level overview", + "title": "Disk Utilization: Node-level Overview", "type": "row" } ], From 89e5be26d1f624100ec6cc6eb6b1f6ea3e94497e Mon Sep 17 00:00:00 2001 From: hardikl Date: Wed, 4 Oct 2023 14:19:56 +0530 Subject: [PATCH 4/4] feat: handle review comment --- grafana/dashboards/cmode/disk.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/grafana/dashboards/cmode/disk.json b/grafana/dashboards/cmode/disk.json index b368c2827..818da7ae3 100644 --- a/grafana/dashboards/cmode/disk.json +++ b/grafana/dashboards/cmode/disk.json @@ -1443,7 +1443,7 @@ "format": "time_series", "instant": false, "interval": "", - "legendFormat": "{{cluster}} - {{disk}}", + "legendFormat": "{{cluster}} - {{disk}} - {{plex}} - {{raid}}", "refId": "A" } ], @@ -1535,7 +1535,7 @@ "format": "time_series", "instant": false, "interval": "", - "legendFormat": "{{cluster}} - {{disk}}", + "legendFormat": "{{cluster}} - {{disk}} - {{plex}} - {{raid}}", "refId": "A" } ], @@ -1627,7 +1627,7 @@ "format": "time_series", "instant": false, "interval": "", - "legendFormat": "{{cluster}} - {{disk}}", + "legendFormat": "{{cluster}} - {{disk}} - {{plex}} - {{raid}}", "refId": "A" } ], @@ -1721,7 +1721,7 @@ "format": "time_series", "instant": false, "interval": "", - "legendFormat": "{{cluster}} - {{disk}}", + "legendFormat": "{{cluster}} - {{disk}} - {{plex}} - {{raid}}", "refId": "A" } ],