Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker generate command enhancement #584

Closed
rahulguptajss opened this issue Oct 20, 2021 · 2 comments · Fixed by #669
Closed

docker generate command enhancement #584

rahulguptajss opened this issue Oct 20, 2021 · 2 comments · Fixed by #669
Labels
feature New feature or request priority/P3 lowest status/done

Comments

@rahulguptajss
Copy link
Contributor

Below command should support configurable prometheus, grafana port. Currently they are hardcoded in prom-stack.yml.

bin/harvest generate docker full --port --output harvest-compose.yml
@rahulguptajss rahulguptajss added the feature New feature or request label Oct 20, 2021
@rahulguptajss rahulguptajss changed the title docker generate full enhancement docker generate command enhancement Oct 20, 2021
@ruanruijuan ruanruijuan added the priority/P3 lowest label Oct 20, 2021
@rahulguptajss rahulguptajss self-assigned this Nov 16, 2021
@rahulguptajss rahulguptajss linked a pull request Nov 16, 2021 that will close this issue
feat: docker generate command enhancement #669
Merged
@rahulguptajss
Copy link
Contributor Author

pending doc changes

@cgrinds cgrinds assigned cgrinds and unassigned cgrinds and rahulguptajss Feb 10, 2022
@cgrinds
Copy link
Collaborator

cgrinds commented Feb 10, 2022

Verified release/22.02.0 bae2dc8 that bin/harvest generate docker full --port --output harvest-compose2.yml --grafanaPort 3333 --promPort 191919 creates a prom-stack.yml with those exposed ports

@cgrinds cgrinds removed their assignment May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request priority/P3 lowest status/done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: docker generate command enhancement NetApp/harvest
3 participants
@cgrinds @rahulguptajss @ruanruijuan