Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZapiPerf/RestPerf Collector Parity #2331

Closed
rahulguptajss opened this issue Aug 28, 2023 · 1 comment · Fixed by #2342
Closed

ZapiPerf/RestPerf Collector Parity #2331

rahulguptajss opened this issue Aug 28, 2023 · 1 comment · Fixed by #2342
Labels
23.11 feature New feature or request status/done

Comments

@rahulguptajss
Copy link
Contributor

rahulguptajss commented Aug 28, 2023 •
edited
Loading

RestPerf doesn't seem to implement below. Check and support the same.

https://github.com/NetApp/harvest/blob/main/cmd/collectors/zapiperf/zapiperf.go#L1013-L1017

image
@rahulguptajss rahulguptajss added the feature New feature or request label Aug 28, 2023
@rahulguptajss rahulguptajss self-assigned this Aug 28, 2023
@cgrinds cgrinds added the 23.11 label Aug 28, 2023
@rahulguptajss rahulguptajss linked a pull request Sep 5, 2023 that will close this issue
feat: add parity for string types between RestPerf and ZapiPerf #2342
Merged
@rahulguptajss rahulguptajss removed their assignment Nov 6, 2023
@rahulguptajss
Copy link
Contributor Author

verified in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
23.11 feature New feature or request status/done
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add parity for string types between RestPerf and ZapiPerf NetApp/harvest
2 participants
@cgrinds @rahulguptajss