Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure collectors and pollers recover panics #105

Closed
1 of 3 tasks
cgrinds opened this issue Jun 2, 2021 · 3 comments
Closed
1 of 3 tasks

Ensure collectors and pollers recover panics #105

cgrinds opened this issue Jun 2, 2021 · 3 comments
Labels
bug Something isn't working priority/P0 highest status/done

Comments

@cgrinds
Copy link
Collaborator

cgrinds commented Jun 2, 2021 •
edited
Loading

Code review collectors and pollers to make sure they recover from all panics

Related to Martin Möbius's message on slack

I have an issue that the pollers just stop running without any log output. Any ideas how to troubleshoot that?
Happens after running for some days

  • Add more unit tests to cover panics in poller/collectors
  • Include more longevity testing in lab that monitors for this
  • Update Troubleshooting to include details
@cgrinds cgrinds added feature New feature or request priority/P0 highest labels Jun 2, 2021
@cgrinds
Copy link
Collaborator Author

cgrinds commented Jun 3, 2021

Related #107

@mamoep
Copy link

mamoep commented Jun 7, 2021

I checked again. After doing "switchdisable" of a MCC backend FC switch, the poller stopped. Last message with loglevel 0:
2021/06/07 13:02:45 (debug ) (collector) (ZapiPerf:Path): fetching data of instance [node-01:kernel:0g.210000108663aec8] I guess that won't help much.

@cgrinds cgrinds added bug Something isn't working status/open and removed feature New feature or request labels Jun 8, 2021
@rahulguptajss
Copy link
Contributor

@cgrinds Should this be in testme or done?

@cgrinds cgrinds closed this as completed Jun 10, 2021
@cgrinds cgrinds mentioned this issue Jul 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority/P0 highest status/done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cgrinds @rahulguptajss @mamoep