Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

函数式组件,props.children 和三元运算符共存时不会被转换为 <slot /> #4293

Closed
fjc0k opened this issue Aug 26, 2019 · 3 comments
Assignees

Comments

@fjc0k
Copy link
Contributor

fjc0k commented Aug 26, 2019

问题描述

函数式组件,props.children 和三元运算符共存时不会被转换为 <slot></slot>但在基于类的组件中会被转换。

复现步骤

组件:

function XTitle(props) {
      return (
         <View className='title'>
          {
            props.title === ''
              ? props.children
              : <Text>{props.title}</Text>
          }
        </View>
     )
}

会被转换为:

        <view class="title">
            <block>
                <block wx:if="{{props.title === ''}}">{{props.children}}</block>
                <block wx:else><text>{{props.title}}</text>
                </block>
            </block>
        </view>

期望行为

props.children 和三元运算符共存时被转换为 <slot></slot>

报错信息

props.children 和三元运算符共存时没有被转换为 <slot></slot>

系统信息

Taro CLI 1.3.14 environment info:
    System:
      OS: macOS High Sierra 10.13.6
      Shell: 5.3 - /bin/zsh
    Binaries:
      Node: 10.16.0 - /usr/local/bin/node
      Yarn: 1.7.0 - /usr/local/bin/yarn
      npm: 6.9.0 - /usr/local/bin/npm
    npmPackages:
      @tarojs/cli: 1.3.14 => 1.3.14 
      @tarojs/components: 1.3.14 => 1.3.14 
      @tarojs/plugin-babel: 1.3.14 => 1.3.14 
      @tarojs/plugin-csso: 1.3.14 => 1.3.14 
      @tarojs/plugin-sass: 1.3.14 => 1.3.14 
      @tarojs/plugin-uglifyjs: 1.3.14 => 1.3.14 
      @tarojs/router: 1.3.14 => 1.3.14 
      @tarojs/taro: 1.3.14 => 1.3.14 
      @tarojs/taro-alipay: 1.3.14 => 1.3.14 
      @tarojs/taro-h5: 1.3.14 => 1.3.14 
      @tarojs/taro-swan: 1.3.14 => 1.3.14 
      @tarojs/taro-tt: 1.3.14 => 1.3.14 
      @tarojs/taro-weapp: 1.3.14 => 1.3.14 
      @tarojs/webpack-runner: 1.3.14 => 1.3.14 
      nerv-devtools: ^1.4.0 => 1.4.3 
      nervjs: ^1.4.0 => 1.4.3 
@taro-bot
Copy link

taro-bot bot commented Aug 26, 2019

欢迎提交 Issue~

如果你提交的是 bug 报告,请务必遵循 Issue 模板的规范,尽量用简洁的语言描述你的问题,最好能提供一个稳定简单的复现。🙏🙏🙏

如果你的信息提供过于模糊或不足,或者已经其他 issue 已经存在相关内容,你的 issue 有可能会被关闭。

Good luck and happy coding~

@taro-bot
Copy link

taro-bot bot commented Aug 26, 2019

CC @yuche

@yuche yuche closed this as completed in 80642bc Aug 26, 2019
@fjc0k
Copy link
Contributor Author

fjc0k commented Aug 26, 2019

@yuche 赞👍 不过这种直接 return 一个条件的情况还是没有被转换哈:

return props.disabled ? props.children : (
  <View />
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants