Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use commit command in VimR #438

Closed
michael-ball opened this issue Jan 27, 2023 · 3 comments
Closed

Unable to use commit command in VimR #438

michael-ball opened this issue Jan 27, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@michael-ball
Copy link

Description

I am unable to commit anything when using VimR.

Neovim version

VimR v0.44.0-20230103.174333
neovim 0.8.2

Operating system and version

macos 12.3

Steps to reproduce

  1. Make a change to a file in a git repository
  2. Stage the file
  3. Use the neogit 'commit' command to try to commit the change

Expected behavior

No response

Actual behavior

The following error is shown:

git --no-pager -c color.ui=always --no-optional-locks commit
hint: Waiting for your editor to close the file... error: '/Applications/VimR.app/Contents/Resources/NvimView_NvimView.bundle/Contents/Resources/NvimServer' --headless --clean --noplugin -n -R -c 'set runtimepath^=/<user dir redacted>/.local/share/nvim/plugged/neogit' -c 'lua require("neogit.client").client()' died of signal 11

Process exited with code: 1

Minimal config

vim.cmd([[set runtimepath=$VIMRUNTIME]])
vim.cmd([[set packpath=/tmp/nvim/site]])
local package_root = "/tmp/nvim/site/pack"
local install_path = package_root .. "/packer/start/packer.nvim"
local function load_plugins()
  require("packer").startup({
    {
      "wbthomason/packer.nvim",
      {
        "TimUntersberger/neogit",
        requires = {
          { "nvim-lua/plenary.nvim" },
          { "sindrets/diffview.nvim" },
        },
        config = function()
          print("loaded neogit")
          require("neogit").setup()
        end,
      },
    },
    config = {
      package_root = package_root,
      compile_path = install_path .. "/plugin/packer_compiled.lua",
      display = { non_interactive = true },
    },
  })
end
if vim.fn.isdirectory(install_path) == 0 then
  print("Installing neogit and dependencies.")
  vim.fn.system({ "git", "clone", "--depth=1", "https://github.com/wbthomason/packer.nvim", install_path })
end
load_plugins()
require("packer").sync()
@michael-ball michael-ball added the bug Something isn't working label Jan 27, 2023
@armincerf
Copy link

Same issue here, am sure it used to work with VimR. Not sure if its a VimR problem or a neogit problem though...

@thecontinium
Copy link

I'm getting a similar or the same problem on Neovim on trying to commit

> git --no-pager -c color.ui=always --no-optional-locks commit
hint: Waiting for your editor to close the file... Error detected while processing command line:
E5108: Error executing lua ...thew/.local/share/nvim/lazy/neogit/lua/neogit/client.lua:43: NVIM server address not set
stack traceback:
        [C]: in function 'error'
        ...thew/.local/share/nvim/lazy/neogit/lua/neogit/client.lua:43: in function 'client'
Command "git --no-pager -c color.ui=always --no-optional-locks commit" running for more than: 2.1 seconds

@CKolkey
Copy link
Member

CKolkey commented Sep 26, 2023

I'm pretty sure that this isn't going to work with a vim GUI. The commit editor is a spawned process that the plugin talks to via RPC...

@CKolkey CKolkey closed this as completed Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants