Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shyfox feels laggy/slow #135

Closed
KAGEYAM4 opened this issue Aug 18, 2024 · 4 comments
Closed

Shyfox feels laggy/slow #135

KAGEYAM4 opened this issue Aug 18, 2024 · 4 comments
Labels
invalid This doesn't seem right

Comments

@KAGEYAM4
Copy link

In the video below left is shyfox in a new firefox profile, right is my different firefox setup. In the video you can see the shadow behind the selected context menu item as i move my mouse over them. In shyfox it feels laggy. This is the same in floating addressbar which was improved when i turned off floating search off, but it was still laggy with floating addressbar which gets improved when i turn off floating addressbar.

2024-08-18.20-22-30.mp4

Is there some kind of custom implementation being used for contex menu ?

@KAGEYAM4 KAGEYAM4 changed the title shyfox feels laggy/slow Shyfox feels laggy/slow Aug 18, 2024
@Naezr
Copy link
Owner

Naezr commented Aug 18, 2024

Is there some kind of custom implementation being used for contex menu ?

All changes to the context menu:

Color:
https://github.com/Naezr/ShyFox/blob/73a25ebd70f5c02fe61dc96467550b8b8f146d3b/chrome/ShyFox/shy-global.css#L290C1-L339C1

Size:
https://github.com/Naezr/ShyFox/blob/73a25ebd70f5c02fe61dc96467550b8b8f146d3b/chrome/ShyFox/shy-compact.css#L5C1-L41C119

Space for icons:
https://github.com/Naezr/ShyFox/blob/73a25ebd70f5c02fe61dc96467550b8b8f146d3b/chrome/ShyFox/shy-icons.css#L289C1-L299C65


ShyFox is really complicated. Version 4.0 will be even more complicated (see the announcement in the discussion tab). But there’s no other way to do it. Many complex css selectors can be simplified by injecting a custom script into Firefox. Maybe someday ShyFox will turn into a full-fledged fork of Firefox or something. However, now there are quite complicated selectors that can possibly cause lags. My laptop is not the most powerful and everything works well for me so I don't know really

@Naezr Naezr added the invalid This doesn't seem right label Aug 18, 2024
@KAGEYAM4
Copy link
Author

v4.0 gonna be awesome. Thanks for you work.

Not sure if it will help or not, but i was using https://github.com/black7375/Firefox-UI-Fix before shyfox. It also modifies context menu but not that heavily, here's all of its options -> https://github.com/black7375/Firefox-UI-Fix/wiki/Options.

@KAGEYAM4
Copy link
Author

KAGEYAM4 commented Aug 26, 2024

@Naezr i also noticed lag/glitch animation when scrolling page.

Steps to reproduce ->

  1. Go to some site which has large vertical content. (small is good too)
  2. Perform small swipe using touchpad but enough swipe to produce animation for 2 seconds.
  3. Animation would lag.

@KAGEYAM4
Copy link
Author

@Naezr wanted to share another behaviour where lags increases ->

Toggling - Style2, Style3, Style4 creates lag. Style1 dosen't create lag

2024-09-17.05-01-08.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants