Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add premerge checks for checking unshimmed classes for binary differences between shims #9578

Open
NVnavkumar opened this issue Oct 30, 2023 · 0 comments
Labels
feature request New feature or request

Comments

@NVnavkumar
Copy link
Collaborator

Build issues like #9571 usually arise from compiling and recompiling classes that result in different bytecode versions of classes that are "unshimmed" (that is classes that should be shared between shims without any bytecode differences). This can happen due to creating dependencies on shim classes when they cannot exist and now even differences between Scala compilers, and other build issues with parallel worlds.

We should add a check for these bytecode differences between different shim versions on unshimmed classes that can occur.

See #9571 (comment) for a basic reproduce of the original error and other notes on the build.

@NVnavkumar NVnavkumar added feature request New feature or request ? - Needs Triage Need team to review and classify labels Oct 30, 2023
@mattahrens mattahrens removed the ? - Needs Triage Need team to review and classify label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants