Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy dedup error if partition wise indices do not start from 0 #48

Open
ayushdg opened this issue May 2, 2024 · 0 comments
Open

Fuzzy dedup error if partition wise indices do not start from 0 #48

ayushdg opened this issue May 2, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@ayushdg
Copy link
Collaborator

ayushdg commented May 2, 2024

Describe the bug

By default when reading from json/parquet files, unless an index is specified, Curator typically reads in each partition with an index ranging from 0->len(partition). However for dataframes where this is not the case, Fuzzy dedup might fail.

Steps/Code to reproduce bug

Reproducer in #46 tests, root cause seems to be coming from

left_df["_partitions"] = global_partitioning_index % parts_per_bucket_batch
where the lhs df might have different indices but the rhs starts from 0 resulting in assignment.

Expected behavior

No errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant