-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flower Integration V2 #3216
Merged
Merged
Flower Integration V2 #3216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added some comments
/build |
YuanTingHsieh
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
/build |
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
This PR implements Flower Integration Version 2 to use Flower's new architecture.
In Flower's previous architecture, on the server side, there are two processes: the superlink process and the server-app process. Flare is responsible for starting and stopping both processes. On client side, the supernode and client-app are included into a single process, and Flare is responsible fro starting and stopping this process.
In the new Flower architecture, on the server side, there is a superlink process, and Flare is responsible for starting and stopping this process. Once started, Flare issues the "flwr run" command to the superlink to submit a Flower app. In the meanwhile, Flare issues the "flwr ls" command periodically to query the status of the submitted app until the app is finished. On the client side, there is one process called Supernode, and Flare is responsible for starting and stopping this process. Flare does not need to start the server-app or client-app processes - these will be managed by the Flower system.
The overall integration architecture remains the same. The only difference is how to start and stop Flower apps.
Types of changes
./runtest.sh
.