Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5] Remove test/predict in lightning fl example #3185

Merged

Conversation

YuanTingHsieh
Copy link
Collaborator

Issue

When using the external process (SubprocessLauncher)

(1) In the last round the CJ will consider the job finish right after "fit" is called, thus the predict/test stage of external program will be killed in the middle

(2) the standalone lightning training script (examples/hello-world/ml-to-fl/pt/src/cifar10_lightning_original.py) is not working because of import (from src.net import Net)

Description

  • Remove the test/predict stage as it is not required
  • Move the Net definition inside the lit_net.py file so import will not be an issue when running standalone lightning training

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@nvidianz
Copy link
Collaborator

/build

@YuanTingHsieh YuanTingHsieh merged commit 978a42d into NVIDIA:2.5 Jan 28, 2025
20 checks passed
@YuanTingHsieh YuanTingHsieh deleted the enhance_lightning_example_25 branch January 28, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants