[2.5] Remove test/predict in lightning fl example #3185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When using the external process (SubprocessLauncher)
(1) In the last round the CJ will consider the job finish right after "fit" is called, thus the predict/test stage of external program will be killed in the middle
(2) the standalone lightning training script (
examples/hello-world/ml-to-fl/pt/src/cifar10_lightning_original.py
) is not working because of import (from src.net import Net
)Description
Types of changes
./runtest.sh
.