Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve metrics streaming #2722

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Improve metrics streaming #2722

merged 5 commits into from
Feb 21, 2025

Conversation

YuanTingHsieh
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh commented Jul 22, 2024 •
edited
Loading

Issue

  • apis should not depend on app_common
  • Some metrics receiver support client side, some don't. If users mis-configure metrics streaming, its error handling should NOT stop the training job.

Description

  • Move LogWriterName, TrackConst from nvflare.app_common.tracking.tracker_types to nvflare.apis.analytix
  • Remove unused file
  • Add supporting type of metrics receiver (either on server side only or both sides)
  • Enhance error handling

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@YuanTingHsieh YuanTingHsieh mentioned this pull request Jul 23, 2024
Merged
6 tasks
@YuanTingHsieh YuanTingHsieh force-pushed the improve_metrics_streaming branch 2 times, most recently from a01ddd6 to a7c9c51 Compare July 23, 2024 01:05
@YuanTingHsieh YuanTingHsieh changed the title [DRAFT] Improve metrics streaming Improve metrics streaming Jul 23, 2024
@YuanTingHsieh YuanTingHsieh force-pushed the improve_metrics_streaming branch 2 times, most recently from b35cac5 to 2a6a6f6 Compare July 30, 2024 20:36
@YuanTingHsieh YuanTingHsieh changed the title Improve metrics streaming [2.6] Improve metrics streaming Jul 30, 2024
@YuanTingHsieh YuanTingHsieh force-pushed the improve_metrics_streaming branch from 7c7ef8a to 94ace50 Compare November 25, 2024 23:16
@YuanTingHsieh YuanTingHsieh changed the title [2.6] Improve metrics streaming Improve metrics streaming Nov 25, 2024
@YuanTingHsieh YuanTingHsieh force-pushed the improve_metrics_streaming branch from 7f7a7b8 to 6bf6bdc Compare November 25, 2024 23:39
@YuanTingHsieh YuanTingHsieh force-pushed the improve_metrics_streaming branch from 00453ea to 63a2c30 Compare February 13, 2025 23:38
nvkevlu
nvkevlu approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@nvkevlu nvkevlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reorganizing and cleaning this up, LGTM

@nvkevlu
Copy link
Collaborator

nvkevlu commented Feb 14, 2025

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh merged commit 0a8d273 into NVIDIA:main Feb 21, 2025
20 checks passed
@YuanTingHsieh YuanTingHsieh deleted the improve_metrics_streaming branch February 21, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvkevlu nvkevlu nvkevlu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YuanTingHsieh @nvkevlu