Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] possible bug in fft plan #269

Closed
luitjens opened this issue Sep 8, 2022 · 0 comments · Fixed by #270
Closed

[BUG] possible bug in fft plan #269

luitjens opened this issue Sep 8, 2022 · 0 comments · Fixed by #270

Comments

@luitjens
Copy link
Collaborator

luitjens commented Sep 8, 2022

https://github.com/NVIDIA/MatX/blob/main/include/matx/transforms/fft.h#L706-L708

in GetFFTInputView we have this code:

// FFT shorter than the size of the input signal. Create a new view of this
// slice.
if (act_fft_size < nom_fft_size) {
  ends[RANK - 1] = nom_fft_size;
  return i.Slice(starts, ends);
}

Upon review it appears that act_fft_size is the size requested and nom_fft_size is the size of the input.

We are setting the slice to the full size instead of the fft size which I believe is a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant