[BUG] An empty macro MATX_ASSERT_STR_EXP is missing in matx_error.h when NDEBUG is defined

[AtomicVar]

Describe the bug
An empty macro MATX_ASSERT_STR_EXP is missing in matx_error.h when NDEBUG is defined.

When building with -DNDEBUG (e.g. cmake with -DCMAKE_BUILD_TYPE=Release), this error will be thrown by the compiler:

/usr/local/include/matx_einsum.h(105): error: identifier "MATX_ASSERT_STR_EXP" is undefined

Expected behavior
An empty definition of MATX_ASSERT_STR_EXP should be added between #else and #endif, just like MATX_ASSERT and MATX_ASSERT_STR.

System details (please complete the following information):

• OS: Ubuntu 20.04
• CUDA version: CUDA 11.4
• g++ version: 9.3.0

[cliffburdick]

Thanks for catching this @ZJUGuoShuai . This has been fixed.

[AtomicVar]

@cliffburdick I suddenly realized that it's not OK to use MATX_ASSERT_* to wrap cutensornet* APIs in matx_einsum.h because if I build it in release mode (with -DNDEBUG), these APIs will be replaced by emtpy lines.

Actually I tried to compiled a einsum() program with -DNDEBUG and ran it, it really did no computation.

[cliffburdick]

Thanks @ZJUGuoShuai. fixing it now

[cliffburdick]

Hi @ZJUGuoShuai , it should be fixed. I verified the einsum tests pass in both debug and release mode.