Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter oEmbed has changed #431

Open
triplingual opened this issue Nov 11, 2019 · 0 comments
Open

Twitter oEmbed has changed #431

triplingual opened this issue Nov 11, 2019 · 0 comments

Comments

@triplingual
Copy link

The oEmbed API endpoint for embedding tweets has changed.
In (VCO.Media.Twitter.js)[https://github.com/NUKnightLab/StoryMapJS/blob/master/source/js/media/types/VCO.Media.Twitter.js] line 31, the code reads
api_url = "https://api.twitter.com/1/statuses/oembed.json?id=" + this.media_id + "&omit_script=true&include_entities=true&callback=?";
Now the pattern would be api_url = https://publish.twitter.com/oembed?url=" + this.media.id, e.g. https://publish.twitter.com/oembed?url=https://twitter.com/Interior/status/463440424141459456

I haven't looked to see what the difference is in the returned JSON, hence why I'm filing as an issue rather than forking and creating a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant