Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a "partial" availability analysis for datasets without all the necessary inputs #203

Open
kandersolar opened this issue Oct 1, 2020 · 0 comments

Comments

@kandersolar
Copy link
Member

Is your feature request related to a problem? Please describe.
The AvailabilityAnalysis class added in #131 requires four inputs: system power, subsystem power, system cumulative energy, and system expected power. The AvailabilityAnalysis class implements two separate analysis strategies, each of which needs only a subset of the three measured fields, but there is no way to only run one of the strategies for datasets that don't have all the fields.

Describe the solution you'd like
Some way to provide the class with only a subset of the inputs and run whichever strategy uses only those inputs. E.g. if a system doesn't have cumulative energy data, then run whatever analysis can be done without it instead of failing immediately.

Describe alternatives you've considered
None

Additional context
The notebook currently shows one way of "getting around" this requirement, but it's sort of hacky and is only half of the desired solution -- it only gives results for loss_system, but the other way round (only giving results for loss_subsystem) isn't possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant