Cleanup of radiation (clouds) - microphysics interaction (based on #33)

[climbfuji]

This PR contains:

• PR Follow up commit for Cleanup of Thompson MP cloud effective radii cal… #33 "Follow up commit for Cleanup of Thompson MP cloud effective radii calculation" from @joeolson42 and @tanyasmirnova, which cleans up the radiation (clouds) - microphysics interaction
• correction of typos in comments in physics/module_SGSCloud_RadPre.F90

Associated PRs:
#35
NOAA-GSL/fv3atm#33
NOAA-GSL/ufs-weather-model#26

For regression testing information, see below NOAA-GSL/ufs-weather-model#26.

[tanyasmirnova]

@joeolson42 Joe, a couple questions:

1. Do you think that Xu-Randall cloud fraction should be computed only from qc+qi, and not all hydrometeors?
2. In the WRF code we added MYNN sub-grid clouds to existing QC and QI:
   qc(i,k,j)=qc(i,k,j) + QC_BL(i,k,j)*(MIN(1., MAX(0., (t(i,k,j)-254.)/15.)))CLDFRA_BL(i,k,j)
   qi(i,k,j)=qi(i,k,j) + QC_BL(i,k,j)(1. - MIN(1., MAX(0., (t(i,k,j)-254.)/15.)))*CLDFRA_BL(i,k,j)
   And in SGSCloud_RadPre we replace QC, QI with QC_BL and QI_BL:
   qc(i,k) = qc_bl(i,k)*cldfra_bl(i,k)
   Is it the intent?
3. If GFDL MP runs together with MYNN PBL, you propose to use MYNN cloud fraction instead of internal GFDL cloud fraction. Is it correct?

[climbfuji]

@joeolson42 Joe, a couple questions:

1. Do you think that Xu-Randall cloud fraction should be computed only from qc+qi, and not all hydrometeors?
2. In the WRF code we added MYNN sub-grid clouds to existing QC and QI:
   qc(i,k,j)=qc(i,k,j) + QC_BL(i,k,j)*(MIN(1., MAX(0., (t(i,k,j)-254.)/15.)))CLDFRA_BL(i,k,j)
   qi(i,k,j)=qi(i,k,j) + QC_BL(i,k,j)(1. - MIN(1., MAX(0., (t(i,k,j)-254.)/15.)))*CLDFRA_BL(i,k,j)
   And in SGSCloud_RadPre we replace QC, QI with QC_BL and QI_BL:
   qc(i,k) = qc_bl(i,k)*cldfra_bl(i,k)
   Is it the intent?
3. If GFDL MP runs together with MYNN PBL, you propose to use MYNN cloud fraction instead of internal GFDL cloud fraction. Is it correct?

What's the way forward? Merge as is or make changes? Results are looking good, all tests completed. I am ready to merge when you are.

[joeolson42]

@joeolson42 <https://github.com/joeolson42> Joe, a couple questions: 1. Do you think that Xu-Randall cloud fraction should be computed only from qc+qi, and not all hydrometeors? In WRF, we replace Xu-Randall entirely with the MYNN clouds. Using more

hydrometeors ruins ceiling forecasts and doesn't have that big of an impact on the SWDOWN.

1. In the WRF code we added MYNN sub-grid clouds to existing QC and QI: qc(i,k,j)=qc(i,k,j) + QC_BL(i,k,j)*(MIN(1., MAX(0., (t(i,k,j)-254.)/15.))) *CLDFRA_BL(i,k,j) qi(i,k,j)=qi(i,k,j) + QC_BL(i,k,j)*(1. - MIN(1., MAX(0., (t(i,k,j)-254.)/15.)))*CLDFRA_BL(i,k,j) And in SGSCloud_RadPre we replace QC, QI with QC_BL and QI_BL: qc(i,k) = qc_bl(i,k)*cldfra_bl(i,k) Is it the intent? This is the intent. We can always change it later if need be. 1. If GFDL MP runs together with MYNN PBL, you propose to use MYNN cloud fraction instead of internal GFDL cloud fraction. Is it correct? Yes, for lack of a better way.

Just merge the code please.

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADLRR3UIWL3S3COXN5CNA53RVENUTANCNFSM4NTFRLPQ> .

-- Joseph Olson Meteorologist Environmental Prediction Advancement Division Global Systems Laboratory NOAA-Earth System Research Labs Boulder, Colorado